Skip to content

CLOUDP-304053: IPA-106:Create - The resource must be the request body #492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 10, 2025
Merged

CLOUDP-304053: IPA-106:Create - The resource must be the request body #492

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
5f28a92
CLOUDP-304053: IPA-106:Create - The resource must be the request body
yelizhenden-mdb Mar 6, 2025
eed1a14
Merge branch 'main' into CLOUDP-304053
yelizhenden-mdb Mar 6, 2025
29c75ff
rule implementation fix
yelizhenden-mdb Mar 6, 2025
5e4caa9
changes in compareSchemas
yelizhenden-mdb Mar 7, 2025
e422df8
use lodash library for deep obj comparison
yelizhenden-mdb Mar 10, 2025
b0cc889
prettier fix
yelizhenden-mdb Mar 10, 2025
394e721
fixes
yelizhenden-mdb Mar 10, 2025
15b9eb3
address the comments
yelizhenden-mdb Mar 10, 2025
debc2ec
address the comments
yelizhenden-mdb Mar 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .github/workflows/spectral-lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,13 @@ jobs:
sparse-checkout: |
openapi/
tools/spectral
- name: Setup Node
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Driveby?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could not find the new libraries I included for the rule, so added these steps

uses: actions/setup-node@v4
with:
node-version: '20.x'
cache: 'npm'
- name: Install npm dependencies
run: npm install
- name: Spectral action
uses: stoplightio/spectral-action@2ad0b9302e32a77c1caccf474a9b2191a8060d83
with:
Expand Down
14 changes: 14 additions & 0 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,9 @@
"apache-arrow": "^19.0.1",
"dotenv": "^16.4.7",
"eslint-plugin-jest": "^28.10.0",
"lodash": "^4.17.21",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: lodash library is used for deep object comparison

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea to use it for now.
In the past experience I have always started with it and then implemented custom versions to cover corner cases :)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fingers crossed hope we will not need custom one, but let's see :D

"markdown-table": "^3.0.4",
"omit-deep-lodash": "^1.1.7",
Copy link
Collaborator Author

@yelizhenden-mdb yelizhenden-mdb Mar 10, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: omit-deep-lodash library is used for recursive omitting

"openapi-to-postmanv2": "4.25.0",
"parquet-wasm": "^0.6.1"
},
Expand Down
Loading
Loading