-
Couldn't load subscription status.
- Fork 14
CLOUDP-302671: Add filter command that removes x-xgen extensions from OAS #495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Do you plan to enable filters for merges to main? Would we have dev branch affected? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| Short: `Filter Open API specification removing hidden endpoints and extension metadata. | ||
| If a version is provided, versioning filters will also be applied.`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we define a flag with the name of the filter to apply? I am wondering a flag would help to clarify what filters will be applied to the spec
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought about it, but since we don't have a use case I would rather only give the two options for now, to avoid generating several different specs with different filters applied
| outputPath: "foas.html", | ||
| externalPaths: externalPaths, | ||
| basePath: "base.json", | ||
| format: "json", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| format: "json", | |
| jsonFormat: "json", |
Proposed changes
Jira ticket: CLOUDP-302671
Testing
Result: 2dd3e79
Checklist
Changes to Spectral
Further comments