Skip to content

CLOUDP-305844: fix branded_preview to avoid listing v2.json/v2.yaml files #517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2025
Merged

CLOUDP-305844: fix branded_preview to avoid listing v2.json/v2.yaml files #517

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions .github/scripts/branded_preview.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,16 @@ while IFS= read -r version; do
versions+=("$version")
done < <(jq -r '.[]' versions.json)

all_urls=(
"https://raw.githubusercontent.com/mongodb/openapi/${branch_name:?}/openapi/v2.json"
"https://raw.githubusercontent.com/mongodb/openapi/${branch_name:?}/openapi/v2.yaml"
)
all_urls=()

# Fetch and append file URLs from each version
for version in "${versions[@]}"; do
if [[ "${version}" == *"private"* ]]; then
all_urls+=("https://raw.githubusercontent.com/mongodb/openapi/${branch_name:?}/openapi/v2/private/openapi-${version}.json")
all_urls+=("https://raw.githubusercontent.com/mongodb/openapi/${branch_name:?}/openapi/v2/private/openapi-${version}.yaml")
continue
fi

Comment on lines +23 to +28
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if [[ "${version}" == *"private"* ]]; then
all_urls+=("https://raw.githubusercontent.com/mongodb/openapi/${branch_name:?}/openapi/v2/private/openapi-${version}.json")
all_urls+=("https://raw.githubusercontent.com/mongodb/openapi/${branch_name:?}/openapi/v2/private/openapi-${version}.yaml")
continue
fi

do we want to add private preview though? I was under the impression that we didn't (note: public preview will be automatically added already)

Copy link
Collaborator Author

@andreaangiolillo andreaangiolillo Mar 11, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the scope we only says that the access to the private preview spec will be within the mongodb/openapi repo. we don't mention branded_preview. I think is a nice addition since we could just share a link to the selected customers with the branded preview link. With that sad, I am open to remove it too

Update: we could also have a branded_private_preview

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no strong opinion from m side, easy enough to revisit

all_urls+=("https://raw.githubusercontent.com/mongodb/openapi/${branch_name:?}/openapi/v2/openapi-${version}.json")
all_urls+=("https://raw.githubusercontent.com/mongodb/openapi/${branch_name:?}/openapi/v2/openapi-${version}.yaml")
done
Expand Down
Loading