CLOUDP-304053: IPA-106:Create - The resource must be the request body (implement deepObjectComparison without third party dependencies) #522
Conversation
… (implement deepObjectComparison without third party dependencies)
… (implement deepObjectComparison without third party dependencies)
| "apache-arrow": "^19.0.1", | ||
| "dotenv": "^16.4.7", | ||
| "eslint-plugin-jest": "^28.10.0", | ||
| "lodash": "^4.17.21", |
| function: 'createMethodShouldNotHaveQueryParameters' | ||
| xgen-IPA-106-create-method-request-body-is-get-method-response: | ||
| description: 'The Create method request should be a Get method response. http://go/ipa/106' | ||
| description: | |
| !isEqual( | ||
| omitDeep(postMethodRequestContentPerMediaType.schema, 'readOnly', 'writeOnly'), | ||
| omitDeep(getMethodResponseContentPerMediaType.schema, 'readOnly', 'writeOnly') | ||
| omitDeep(postMethodRequestContentPerMediaType.schema, ...ignoredValues), |
|
LGTM! Will review fully once put out of draft mode |
| * @param {*} value2 Second value to compare | ||
| * @returns {boolean} Whether the values are deeply equal | ||
| */ | ||
| export function isDeepEqual(value1, value2) { |
There was a problem hiding this comment.
Perhaps it could be useful to add some unit tests for this function specifically? So it's covered by a unit test as well as spectral test in action
There was a problem hiding this comment.
E.g. /__tests__/utils
There was a problem hiding this comment.
Great idea @lovisaberggren Can we create separate jira to have utils (our framework for exceptions and metics) covered by tests. Problem is not specific to this PR.
There was a problem hiding this comment.
Sure, let me create one @wtrocki
Included some test cases for the functions defined in compareUtils.js
There was a problem hiding this comment.
Here is the ticket: https://jira.mongodb.org/browse/CLOUDP-305898
There was a problem hiding this comment.
Thanks, yeah at least for the more complicated helper functions we should have tests
tools/spectral/ipa/__tests__/createMethodRequestBodyIsGetResponse.test.js
Show resolved
Hide resolved
3 participants
Proposed changes
Jira ticket: CLOUDP-304053
This PR implements deep object comparison without third party dependencies, and replace the existing third party solutions
Checklist
Changes to Spectral
Further comments