IPA 106: Create : The response status code must be 201 Created #527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
18
to
20
| if (isCustomMethodIdentifier(resourcePath)) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
Q: Should be skip non-resource collection paths as well?
There was a problem hiding this comment.
I have also been thinking about it lately. Because in IPAs, it is mentioned that make a POST request to a collection's URI. It makes sense to skip non-resource collection paths. I will share another PR refactoring the Create methods with that check
There was a problem hiding this comment.
Cool, yeah then I think we can discard some of the paths that are /resource/resource which may be more of custom cases
There was a problem hiding this comment.
Yeah I think so
There was a problem hiding this comment.
I made the changes for this rule on this PR. For others: #529
lovisaberggren
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Jira ticket: CLOUDP-304941
Create methods must return a 201 Created response code
Checklist
Changes to Spectral
Further comments