Skip to content

Conversation

@yelizhenden-mdb
Copy link
Collaborator

Proposed changes

Includes "This rule applies only to POST requests targeting resource collection URIs." sentence to the IPA-106:Create rules

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works

Changes to Spectral

  • I have read the README file for Spectral Updates

Further comments

@yelizhenden-mdb yelizhenden-mdb marked this pull request as ready for review March 13, 2025 10:58
@yelizhenden-mdb yelizhenden-mdb requested a review from a team as a code owner March 13, 2025 10:58
@wtrocki
Copy link
Member

wtrocki commented Mar 13, 2025

@yelizhenden-mdb @lovisaberggren YAML has multiple formats for multilines. Since our generator uses table format any form of line breaks or markdown like content will break table. To prevent from that we can use >-

Alternatively we can move from table format to chapter format per rule. IMHO that could be much better as each rule can be linked directly in failure mesasge. WDYT?

Copy link
Member

@wtrocki wtrocki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Happy to apply suggestions across the implementation

@wtrocki wtrocki merged commit 936804f into main Mar 13, 2025
13 checks passed
@wtrocki wtrocki deleted the create-method-desc-fix branch March 13, 2025 11:17
@wtrocki
Copy link
Member

wtrocki commented Mar 13, 2025

Merged as I would like to get this one refined as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants