Skip to content

Conversation

@wtrocki
Copy link
Member

@wtrocki wtrocki commented Mar 13, 2025

Proposed changes

First PR covering new documentation standards.
Looking for extra feedback to formalize pattern for follow up PRs.

@wtrocki wtrocki requested a review from a team as a code owner March 13, 2025 16:45
sortedRuleEntries.forEach((rule) => {
const severityFormatted = formatSeverity(rule.severity);
sections += `#### ${rule.name}\n\n ${severityFormatted} \n${rule.description}\n\n`;
sections += `#### ${rule.name}\n\n ${severityFormatted} \n${rule.description}`;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could not understand ####. Should it represent heading level?
It is appended to the end of the IPA principle link in the documentation. Is it expected behavior?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. It is heading. Best way to understand it IMHO is to look at generated readme that is part of PR

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this is a wrong one
http://go/ipa/102#### xgen-IPA-102-collection-identifier-camelCase but it should be something like

http://go/ipa/102
#### xgen-IPA-102-collection-identifier-camelCase

Copy link
Member Author

@wtrocki wtrocki Mar 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. I do not wanted to touch other ipas. Will revert that fix and make it as last fix after all docs changes are done

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to fix those in descriptions by changing way we format multi line descriptions :D

@wtrocki wtrocki merged commit 356445e into main Mar 14, 2025
13 checks passed
@wtrocki wtrocki deleted the CLOUDP-305862-106 branch March 14, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants