-
Notifications
You must be signed in to change notification settings - Fork 14
CLOUDP-305862: IPA 106 documentation standard #537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| sortedRuleEntries.forEach((rule) => { | ||
| const severityFormatted = formatSeverity(rule.severity); | ||
| sections += `#### ${rule.name}\n\n ${severityFormatted} \n${rule.description}\n\n`; | ||
| sections += `#### ${rule.name}\n\n ${severityFormatted} \n${rule.description}`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could not understand ####. Should it represent heading level?
It is appended to the end of the IPA principle link in the documentation. Is it expected behavior?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. It is heading. Best way to understand it IMHO is to look at generated readme that is part of PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this is a wrong one
http://go/ipa/102#### xgen-IPA-102-collection-identifier-camelCase but it should be something like
http://go/ipa/102
#### xgen-IPA-102-collection-identifier-camelCase
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes. I do not wanted to touch other ipas. Will revert that fix and make it as last fix after all docs changes are done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to fix those in descriptions by changing way we format multi line descriptions :D
Proposed changes
First PR covering new documentation standards.
Looking for extra feedback to formalize pattern for follow up PRs.