CLOUDP-271995: Adds rule for update method must not have query param #539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * Create operations should not have query parameters. | ||
| * | ||
| * @param {object} input - The create operation object | ||
| * @param {{ignoredValues: string[]}} opts - Array of ignored query parameters |
There was a problem hiding this comment.
Thanks for the drive-by ❤️
yelizhenden-mdb
approved these changes
Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Adds rules
xgen-IPA-107-put-must-not-have-query-paramsandxgen-IPA-107-patch-must-not-have-query-params. Same validation function, but two rules coveringpatchandputrespectively.Also added
ignoredValues(envelope and pretty) to the existing similar rulexgen-IPA-106-create-method-should-not-have-query-parametersand updated the error message, example:Currently 8 violations for the put/patch rule.
Added tests.
Jira ticket: CLOUDP-271995