CLOUDP-305830: stop filtering x-xgen-changelog from versioned files #540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blva
commented
Mar 14, 2025
| "DigestAuth": [] | ||
| } | ||
| ], | ||
| "x-xgen-changelog": { |
There was a problem hiding this comment.
cleaning up x-xgen-changelog in most tests, but adding it to one of the endpoints
blva
changed the title
andreaangiolillo
approved these changes
Mar 18, 2025
| for _, operation := range pathItem.Operations() { | ||
| if operation.Extensions != nil { | ||
| delete(operation.Extensions, "x-xgen-owner-team") | ||
| delete(operation.Extensions, "x-xgen-changelog") |
There was a problem hiding this comment.
is this line the fix? Do we plan to include this extension for all the specs? I am wondering if we should keep it only for the latest API version spec but not strong opinion
There was a problem hiding this comment.
yes, and I plan to keep it in all specs, I added the removal then caused a regression
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Checklist
Changes to Spectral
Further comments