CLOUDP-304946: IPA rule update must return 200 ok #542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @param errorMessage the error message | ||
| * @returns {*[]|[{path, message}]} the errors found, or an empty array in case of no errors | ||
| */ | ||
| export function checkResponseCodeAndReturnErrors(operationObject, expectedStatusCode, path, ruleName, errorMessage) { |
|
|
||
| if ( | ||
| !isSingleResourceIdentifier(resourcePath) && | ||
| !(isResourceCollectionIdentifier(resourcePath) && isSingletonResource(resourcePaths)) |
There was a problem hiding this comment.
Q: For Update methods, should we consider singleton URIs? I would say we can look only for single resource URIs
There was a problem hiding this comment.
Since singletons should and can have Update methods, we should cover them here as well, similarly to the get methods
There was a problem hiding this comment.
Yes, it is a similar case to Get methods. Cool, thanks!
wtrocki
reviewed
Mar 14, 2025
wtrocki
reviewed
Mar 14, 2025
wtrocki
approved these changes
Mar 14, 2025
wtrocki
reviewed
Mar 14, 2025
tools/spectral/ipa/__tests__/updateResponseCodeShouldBe200OK.test.js
Outdated
Show resolved
Hide resolved
wtrocki
approved these changes
Mar 14, 2025
|
Thank you for the fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Adds rules
xgen-IPA-107-put-method-response-code-is-200andxgen-IPA-107-patch-method-response-code-is-200.Added tests
Also did some refactoring to use a common validation method since we have a lot of similar rules checking for the response code.
Jira ticket: CLOUDP-304946