CLOUDP-305862: replace urls to use public url shortener and direct link to rule #543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| errors.forEach((error, index) => { | ||
| expect(error.code).toEqual(testCase.errors[index].code); | ||
| expect(error.message).toEqual(testCase.errors[index].message); | ||
| expect(error.message).toMatch(testCase.errors[index].message); |
There was a problem hiding this comment.
Q: Why change to match?
There was a problem hiding this comment.
you can use regexp if needed. So basically it is equals when you need equals and regular expression when it is needed. Idea is that we do not need to put lenghtly links in the tests
There was a problem hiding this comment.
e.g in future if we change url shortener no one will need to spent +1 hour adjusting test covering the error url
wtrocki
force-pushed
the
CLOUDP-305862-url-shortener
branch
from
c35000f to
a72f0cc
Compare
wtrocki
force-pushed
the
CLOUDP-305862-url-shortener
branch
from
e29709c to
a8cd82e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Use public shortener instead of go links to link to the rule specification (generated Readme).
Created as single PR across all files to avoid confusion in future rule development