CLOUDP-305862 - Add missing rule Technical Specifications #546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wtrocki
force-pushed
the
CLOUDP-305862-rule-definitions
branch
from
f99c612 to
9eb4700
Compare
|
Rebasing to bring changes from #548 |
wtrocki
force-pushed
the
CLOUDP-305862-rule-definitions
branch
from
e62596c to
9db89a3
Compare
lovisaberggren
approved these changes
Mar 18, 2025
| - Validation ignores resources without a Get method | ||
| ##### Implementation details | ||
| Rule checks for the following conditions: | ||
| - Applies only to POST methods on resource collection paths |
There was a problem hiding this comment.
Suggested change
| - Applies only to POST methods on resource collection paths | |
| - Applies only to POST methods on resource collection paths (non-singleton resources and non-custom methods) |
| ##### Implementation details | ||
| Rule checks for the following conditions: | ||
| - Applies to 204 responses in DELETE methods |
There was a problem hiding this comment.
After CLOUDP-306347, we can also add Applies only to DELETE methods on single resource paths like others
Co-authored-by: Yeliz Henden <[email protected]> Co-authored-by: Lovisa Berggren <[email protected]>
yelizhenden-mdb
approved these changes
Mar 18, 2025
Co-authored-by: Yeliz Henden <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Adding technical specifications for the each rule we have in main.
Pefered way to review -> read README.md file for all the rules