Skip to content

Conversation

@lovisaberggren
Copy link
Collaborator

@lovisaberggren lovisaberggren commented Mar 18, 2025

Proposed changes

Adds rule xgen-IPA-107-update-method-request-has-no-readonly-fields and tests. Also some refactoring of the existing helper validation.

Jira ticket: CLOUDP-304944

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to validations.js since this is a common validation function returning errors

@lovisaberggren lovisaberggren marked this pull request as ready for review March 18, 2025 17:45
@lovisaberggren lovisaberggren requested a review from a team as a code owner March 18, 2025 17:45
Copy link
Collaborator

@yelizhenden-mdb yelizhenden-mdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice drive-by refactoring! LGTM, Thanks!

@lovisaberggren lovisaberggren merged commit a72c7cd into main Mar 18, 2025
8 checks passed
@lovisaberggren lovisaberggren deleted the CLOUDP-304944 branch March 18, 2025 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants