CLOUDP-304942: Adds xgen-IPA-107-update-method-request-body-is-get-method-response #567
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lovisaberggren
commented
Mar 19, 2025
| ); | ||
|
|
||
| const errors = checkViolationsAndReturnErrors( | ||
| const errors = checkRequestResponseResourceEqualityAndReturnErrors( |
There was a problem hiding this comment.
Created common function to be reused
wtrocki
approved these changes
Mar 19, 2025
| mediaType | ||
| ); | ||
|
|
||
| const errors = checkRequestResponseResourceEqualityAndReturnErrors( |
There was a problem hiding this comment.
The Create method checks for equality across all fields except those marked as readOnly or writeOnly. Should we apply the same equality check for the Update method?
The description also refers to this as "the resource or parts of the resource returned by the Get method."
There was a problem hiding this comment.
Discussed offline: IaC tools require Update request schemas to follow the same requirements as Create request schemas
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Adds rule
xgen-IPA-107-update-method-request-body-is-get-method-responseand tests.Reused the same comparison logic as
xgen-IPA-106-create-method-request-body-is-get-method-responseand moved it to a common validation function invalidations.js.13 violations currently.
Jira ticket: CLOUDP-304942