CLOUDP-304958: IPA rule singleton must not have delete #579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yelizhenden-mdb
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Adds IPA 113 rules:
xgen-IPA-113-singleton-must-not-have-delete-methodxgen-IPA-113-singleton-should-have-update-methodNote:
xgen-IPA-113-singleton-must-not-have-delete-methodis covering the statement "Singleton resources must not define the Create or Delete standard methods" however I only implemented the check for DELETE since we use the absence of POST to determine if a resource is a singleton resource.Note:
xgen-IPA-113-singleton-should-have-update-methodin the guidelines mentions GET as well, but this is already covered by a rule for 104, so didn't include this validation here.Testing
xgen-IPA-113-singleton-must-not-have-delete-methodxgen-IPA-113-singleton-should-have-update-methodJira ticket: CLOUDP-304958