-
Notifications
You must be signed in to change notification settings - Fork 14
CLOUDP-304965: IPA rule for descriptions #590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| - '$.info' | ||
| - '$.tags[*]' | ||
| - '$.paths[*][get,put,post,delete,options,head,patch,trace]' | ||
| - '$.paths[*][get,put,post,delete,options,head,patch,trace].parameters[*]' | ||
| - '$.paths[*][get,put,post,delete,options,head,patch,trace]..content..properties[*]' | ||
| - '$.components.schemas..properties[*]' | ||
| - '$.components.parameters[*]' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI wanted to use aliases for these, but got an anonymous error from Spectral, not sure why, perhaps aliases don't work with custom functions. I went like this for now and will see if I can get aliases working, or if I need to open an issue with Spectral
|
Q: Don't we need to run IPA docs generation? |
Hmm yes I'll check why it didn't fail |
|
@yelizhenden-mdb I didn't add the new ruleset to the base ipa-spectral file so it wasn't included in the validation or the docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Proposed changes
Adds rule to check for descriptions presence and empty descriptions, it covers:
It can replace the legacy spectral check we have right now.
The violations are the same as we have for the legacy rule:
Jira ticket: CLOUDP-304965