Fix on xgen-IPA-110-collections-response-define-results-array #615
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wtrocki
reviewed
Mar 26, 2025
| }, | ||
| }, | ||
| }, | ||
| errors: [ |
There was a problem hiding this comment.
Interesting. Renamed rule removes errors?
There was a problem hiding this comment.
There is no functionality change but tests changed. Just check if that is ok
There was a problem hiding this comment.
No, it is test case for exceptions, there should be no errors
There was a problem hiding this comment.
Ah.. so reason why they were errors was wrong name. PR already approved. Thank you for clarification
There was a problem hiding this comment.
Since the rule_name in rule implementation was incorrect, it didn't trigger properly, so errors were expected
wtrocki
approved these changes
Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Jira ticket: CLOUDP-304955
Small fixes around the exception mechanism of
xgen-IPA-110-collections-response-define-results-arrayruleChecklist
Changes to Spectral
Further comments