fix: update the sunset filter to remove the 9999-12-01 also from the operation extension.
#620
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gssbzn
approved these changes
Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces changes to the
SunsetFilterfunctionality in thetools/cli/internal/openapi/filterpackage. The main goal is to enhance the handling of the "sunset" extension within OpenAPI operations and their responses. Additionally, new test cases are added to ensure the correctness of these changes.Enhancements to
SunsetFilter:tools/cli/internal/openapi/filter/sunset.go: Added logic to remove the "sunset" extension if its value is set to "sunsetToBeDecided". This check is performed both within the 20X response and as part of the operation itself. [1] [2]New test cases:
tools/cli/internal/openapi/filter/sunset_test.go: Added a new test case to verify the removal of the "x-sunset" extension when its value is "9999-12-31" and the extension is part of the operation.