CLOUDP-306572: Adds rule for "well defined schema" #634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| function checkViolationsAndReturnErrors(object, path) { | ||
| try { | ||
| const validProperties = [ | ||
| 'schema', |
There was a problem hiding this comment.
q: we can add format, pattern, allowedValues, min, max? Wdyt?
There was a problem hiding this comment.
Since we're only validating type: 'object' these wouldn't be valid/bring clarification on what the object looks like. These keywords are for primitive types
yelizhenden-mdb
approved these changes
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Adds two rules to partially validate IPA 117:
xgen-IPA-117-parameter-has-examples-or-schemacorresponds to the legacy spectral rulexgen-IPA-117-objects-must-be-well-definedchecks that components oftype: 'object'has schema, example(s), properties, additionalProperties or oneOf/anyOf/allOfSee README additions for more details.
Jira ticket: CLOUDP-306572