CLOUDP-304964: IPA-114: Errors (check for 401 and 403 codes for authorized endpoints)

[yelizhenden-mdb]

Proposed changes

Jira ticket: CLOUDP-304964

  xgen-IPA-114-authenticated-endpoints-have-auth-errors:
    description: |
      Authenticated endpoints must define 401 and 403 responses.

      ##### Implementation details
      This rule checks that all authenticated endpoints (those without explicit 'security: []' 
      and not containing '/unauth' in the path) include 401 and 403 responses.

Checklist

• I have signed the MongoDB CLA
• I have added tests that prove my fix is effective or that my feature works

Changes to Spectral

• I have read the README file for Spectral Updates

Further comments

[lovisaberggren]

Suggested change

	given: '$.paths[*][*]'
	given: '$.paths[*][put,patch,get,delete...]'

I think you need to add the methods explicitly here (similarly to a few of the IPA 117 rules), otherwise it will validate extensions as well. I can see in the results:

warning  xgen-IPA-114-authenticated-endpoints-have-auth-errors  Authenticated endpoint must define a 401 and 403 responses. https://mdb.link/mongodb-atlas-openapi-validation#xgen-IPA-114-authenticated-endpoints-have-auth-errors                                                                                                        paths./api/atlas/v2/alertConfigs/matchers/fieldNames.x-xgen-IPA-exception

For: paths./api/atlas/v2/alertConfigs/matchers/fieldNames.x-xgen-IPA-exception

[yelizhenden-mdb]

Nice catch, addressed 👍 507 violations 🥲

[lovisaberggren]

:hidethepainharold: