Skip to content

IPA-114: Errors (remove dedicated 404 check for Delete methods) #641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 1, 2025
Merged

IPA-114: Errors (remove dedicated 404 check for Delete methods) #641

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
138 changes: 0 additions & 138 deletions tools/spectral/ipa/__tests__/IPA108DeleteMethod404Response.test.js
View file
Open in desktop

This file was deleted.

17 changes: 0 additions & 17 deletions tools/spectral/ipa/rulesets/IPA-108.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,22 +36,6 @@ rules:
then:
function: IPA108DeleteMethod204Response

xgen-IPA-108-delete-include-404-response:
description: |
DELETE method must include 404 response and return it when resource not found.

##### Implementation details
Rule checks for the following conditions:
- Applies to all DELETE methods for single resource endpoints (with path parameters)
- Verifies that the method includes a 404 response code
- Fails if the 404 status code is missing from the responses
- Skips validation for collection endpoints (without path parameters)
message: '{{error}} https://mdb.link/mongodb-atlas-openapi-validation#xgen-IPA-108-delete-include-404-response'
severity: error
given: $.paths[*].delete
then:
function: IPA108DeleteMethod404Response

xgen-IPA-108-delete-request-no-body:
description: |
DELETE method must not have request body.
Expand All @@ -72,4 +56,3 @@ functions:
- IPA108DeleteMethodResponseShouldNotHaveSchema
- IPA108DeleteMethod204Response
- IPA108DeleteMethodNoRequestBody
- IPA108DeleteMethod404Response
12 changes: 0 additions & 12 deletions tools/spectral/ipa/rulesets/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,18 +376,6 @@ Rule checks for the following conditions:
- Fails if the 204 status code is missing or if other 2xx responses exist
- Skips validation for collection endpoints (without path parameters)

#### xgen-IPA-108-delete-include-404-response

![error](https://img.shields.io/badge/error-red)
DELETE method must include 404 response and return it when resource not found.

##### Implementation details
Rule checks for the following conditions:
- Applies to all DELETE methods for single resource endpoints (with path parameters)
- Verifies that the method includes a 404 response code
- Fails if the 404 status code is missing from the responses
- Skips validation for collection endpoints (without path parameters)

#### xgen-IPA-108-delete-request-no-body

![error](https://img.shields.io/badge/error-red)
Expand Down
33 changes: 0 additions & 33 deletions tools/spectral/ipa/rulesets/functions/IPA108DeleteMethod404Response.js
View file
Open in desktop

This file was deleted.

Loading