CLOUDP-310538: Remove duplicate legacy rules #669
Conversation
| - "$.components.schemas[*]..properties[?(@ && @.type)]" | ||
|
|
||
| rules: | ||
| xgen-schema-properties-camel-case: |
There was a problem hiding this comment.
Can you check if there are overrides for these below that can be removed?
There was a problem hiding this comment.
Overrides removed for all the removed legacy Spectral rules 👍
There was a problem hiding this comment.
Note: xgen-docs-parameter-examples-or-schema legacy rule will be removed after xgen-IPA-117-parameter-has-examples-or-schema rolled out
Do we have a ticket for this? Or is it covered in one of the existing tickets?
There was a problem hiding this comment.
Created the ticket for the last rollout, and included this one there. Let me know how it sounds
| then: | ||
| function: pattern # casing? | ||
| functionOptions: | ||
| match: "/^[a-z$_]{1}[A-Z09$_]*/" # type: camel ? |
There was a problem hiding this comment.
[To ensure] Is that regexp exactly the same that the one we have or it is least restrictive?
There was a problem hiding this comment.
We are using Spectral's camel casing rule, such as
[CasingType.camel]: '[a-z][a-z{__DIGITS__}]*(?:[A-Z{__DIGITS__}](?:[a-z{__DIGITS__}]+|$))*',
Only difference I can see is that Spectral one does not allow underscores
3 participants
Proposed changes
Jira ticket: CLOUDP-310538
PR removes the legacy Spectral rules which duplicate the current error-level IPA rules according to this table in the Technical Design document
Note:
xgen-docs-parameter-examples-or-schemalegacy rule will be removed afterxgen-IPA-117-parameter-has-examples-or-schemarolled outNote: It is discussed with APIx-2 before, that removal of duplicate legacy rules will not affect any APIx-2 workflow (discussion link)
Checklist
Changes to Spectral
Further comments