-
Notifications
You must be signed in to change notification settings - Fork 14
CLOUDP-311375: Update foascli split
command to support upcoming
apis
#673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
foascli split
command to support upcoming apisfoascli split
command to support upcoming
apis
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
basePath: "../../../test/data/openapi_with_upcoming.json", | ||
outputPath: "foas.yaml", | ||
fs: fs, | ||
env: "dev", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the-absolute-super-nit: set format to yaml so that you only generate a yaml as "all" is the default and we'll generate an unused file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will update it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry i approved can be in your next PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Proposed changes
CLOUDP-311375
This PR updates
foascli split
to add support forupcoming
api version.