Skip to content

Conversation

andreaangiolillo
Copy link
Collaborator

@andreaangiolillo andreaangiolillo commented Apr 8, 2025

Proposed changes

CLOUDP-311375

This PR updates foascli split to add support for upcoming api version.

@andreaangiolillo andreaangiolillo changed the title CLOUDP-311375: Update foascli split command to support upcoming apis CLOUDP-311375: Update foascli split command to support upcoming apis Apr 8, 2025
@andreaangiolillo andreaangiolillo requested a review from Copilot April 8, 2025 13:53
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

@mongodb mongodb deleted a comment from Copilot AI Apr 8, 2025
@andreaangiolillo andreaangiolillo marked this pull request as ready for review April 8, 2025 15:34
@andreaangiolillo andreaangiolillo requested a review from a team as a code owner April 8, 2025 15:34
@andreaangiolillo andreaangiolillo enabled auto-merge (squash) April 8, 2025 15:35
basePath: "../../../test/data/openapi_with_upcoming.json",
outputPath: "foas.yaml",
fs: fs,
env: "dev",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the-absolute-super-nit: set format to yaml so that you only generate a yaml as "all" is the default and we'll generate an unused file

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will update it

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry i approved can be in your next PR

Copy link
Collaborator

@blva blva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andreaangiolillo andreaangiolillo merged commit 4504141 into main Apr 9, 2025
10 checks passed
@andreaangiolillo andreaangiolillo deleted the CLOUDP-311375 branch April 9, 2025 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants