CLOUDP-315586: Add verbose debug logging to Postman collection upload #698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt-condon
commented
Apr 29, 2025
| fi | ||
|
|
||
| # runs curl for provided args without showing sensitive info | ||
| curl "${args[@]}" 2>&1 | grep -i -v "api-key\|x-api-key\|PMAK-" || true |
There was a problem hiding this comment.
Ensuring that when we run the curl with -v, the API key hidden from the logs
blva
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
We're seeing 404s from the Postman API when attempting to send PUT requests on the collection upload in the github action runs
Validated locally and the identical requests are successful and applying the PUT
To help with troubleshooting, adding verbose logging that will be applied only when debug logging is enabled
Also reduced the number of retries as from local verbose logging I can see there are different quotas for rate limits, including a monthly rate limit (may be the incorrect error code returned)
Jira ticket: CLOUDP-315586
Closes #[issue number]
Checklist
Changes to Spectral
Further comments