Skip to content

feat: add dochub link to SDK code sample #775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 17, 2025
Merged

feat: add dochub link to SDK code sample #775

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
360f979
feat: add dochub link to SDK code sample
andreaangiolillo Jun 17, 2025
2bbc5ad
fix e2e test
andreaangiolillo Jun 17, 2025
8ad54d4
Moved go sdk sample to use embed
andreaangiolillo Jun 17, 2025
f6163f4
fixed wind error caused by path
andreaangiolillo Jun 17, 2025
4552979
rename sample file
andreaangiolillo Jun 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion tools/cli/internal/openapi/filter/code_sample.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,8 @@ func main() {
ctx := context.Background()
clientID := os.Getenv("MONGODB_ATLAS_CLIENT_ID")
clientSecret := os.Getenv("MONGODB_ATLAS_CLIENT_SECRET")


// See https://dochub.mongodb.org/core/atlas-go-sdk-oauth
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the main change

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since touching it can you move it to a template file and embed it here? https://pkg.go.dev/embed

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, thanks for the reminder

client, err := sdk.NewClient(
sdk.UseOAuthAuth(clientID, clientSecret),
sdk.UseBaseURL(url))
Expand Down
1 change: 1 addition & 0 deletions tools/cli/internal/openapi/filter/code_sample_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ func TestCodeSampleFilter(t *testing.T) {
"\tctx := context.Background()\n" +
"\tclientID := os.Getenv(\"MONGODB_ATLAS_CLIENT_ID\")\n" +
"\tclientSecret := os.Getenv(\"MONGODB_ATLAS_CLIENT_SECRET\")\n\n" +
"\t// See https://dochub.mongodb.org/core/atlas-go-sdk-oauth\n" +
"\tclient, err := sdk.NewClient(\n" +
"\t\tsdk.UseOAuthAuth(clientID, clientSecret),\n" +
"\t\tsdk.UseBaseURL(url))\n\n" +
Expand Down
111,958 changes: 55,979 additions & 55,979 deletions tools/cli/test/data/split/dev/openapi-v2-2023-01-01.json
View file
Open in desktop

Large diffs are not rendered by default.

113,466 changes: 56,733 additions & 56,733 deletions tools/cli/test/data/split/dev/openapi-v2-2023-02-01.json
View file
Open in desktop

Large diffs are not rendered by default.

Loading
Loading