Skip to content

fix: remove UseBaseURL from the go sdk example #782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2025
Merged

fix: remove UseBaseURL from the go sdk example #782

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions tools/cli/internal/openapi/filter/code_sample_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,9 +94,7 @@ func TestCodeSampleFilter(t *testing.T) {
"\tclientID := os.Getenv(\"MONGODB_ATLAS_CLIENT_ID\")\n" +
"\tclientSecret := os.Getenv(\"MONGODB_ATLAS_CLIENT_SECRET\")\n\n" +
"\t// See https://dochub.mongodb.org/core/atlas-go-sdk-oauth\n" +
"\tclient, err := sdk.NewClient(\n" +
"\t\tsdk.UseOAuthAuth(clientID, clientSecret),\n" +
"\t\tsdk.UseBaseURL(url))\n\n" +
"\tclient, err := sdk.NewClient(sdk.UseOAuthAuth(clientID, clientSecret))\n\n" +
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

main change

"\tif err != nil {\n" + "\t\tlog.Fatalf(\"Error: %v\", err)\n\t}\n\n" +
"\tparams = &sdk.TestOperationIDApiParams{}\n" +
"\tsdkResp, httpResp, err := client.TestTagApi.\n" +
Expand Down
4 changes: 1 addition & 3 deletions tools/cli/internal/openapi/filter/template/go_sdk_code_sample.go.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,7 @@ func main() {
clientSecret := os.Getenv("MONGODB_ATLAS_CLIENT_SECRET")

// See https://dochub.mongodb.org/core/atlas-go-sdk-oauth
client, err := sdk.NewClient(
sdk.UseOAuthAuth(clientID, clientSecret),
sdk.UseBaseURL(url))
client, err := sdk.NewClient(sdk.UseOAuthAuth(clientID, clientSecret))

if err != nil {
log.Fatalf("Error: %v", err)
Expand Down
674 changes: 337 additions & 337 deletions tools/cli/test/data/split/dev/openapi-v2-2023-01-01.json
View file
Open in desktop

Large diffs are not rendered by default.

1,348 changes: 337 additions & 1,011 deletions tools/cli/test/data/split/dev/openapi-v2-2023-01-01.yaml
View file
Open in desktop

Large diffs are not rendered by default.

698 changes: 349 additions & 349 deletions tools/cli/test/data/split/dev/openapi-v2-2023-02-01.json
View file
Open in desktop

Large diffs are not rendered by default.

1,396 changes: 349 additions & 1,047 deletions tools/cli/test/data/split/dev/openapi-v2-2023-02-01.yaml
View file
Open in desktop

Large diffs are not rendered by default.

726 changes: 363 additions & 363 deletions tools/cli/test/data/split/dev/openapi-v2-2023-10-01.json
View file
Open in desktop

Large diffs are not rendered by default.

1,452 changes: 363 additions & 1,089 deletions tools/cli/test/data/split/dev/openapi-v2-2023-10-01.yaml
View file
Open in desktop

Large diffs are not rendered by default.

752 changes: 376 additions & 376 deletions tools/cli/test/data/split/dev/openapi-v2-2023-11-15.json
View file
Open in desktop

Large diffs are not rendered by default.

1,504 changes: 376 additions & 1,128 deletions tools/cli/test/data/split/dev/openapi-v2-2023-11-15.yaml
View file
Open in desktop

Large diffs are not rendered by default.

788 changes: 394 additions & 394 deletions tools/cli/test/data/split/dev/openapi-v2-2024-05-30.json
View file
Open in desktop

Large diffs are not rendered by default.

1,576 changes: 394 additions & 1,182 deletions tools/cli/test/data/split/dev/openapi-v2-2024-05-30.yaml
View file
Open in desktop

Large diffs are not rendered by default.

788 changes: 394 additions & 394 deletions tools/cli/test/data/split/dev/openapi-v2-2024-08-05.json
View file
Open in desktop

Large diffs are not rendered by default.

1,576 changes: 394 additions & 1,182 deletions tools/cli/test/data/split/dev/openapi-v2-2024-08-05.yaml
View file
Open in desktop

Large diffs are not rendered by default.

800 changes: 400 additions & 400 deletions tools/cli/test/data/split/dev/openapi-v2-2025-01-01.json
View file
Open in desktop

Large diffs are not rendered by default.

1,600 changes: 400 additions & 1,200 deletions tools/cli/test/data/split/dev/openapi-v2-2025-01-01.yaml
View file
Open in desktop

Large diffs are not rendered by default.

Loading