CLOUDP 328960: OperationID Validation function for :action custom methods #815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
July 8, 2025 17:25
Comment on lines
19
to
24
| let obj; | ||
| if (input.post) { | ||
| obj = input.post; | ||
| } else if (input.get) { | ||
| obj = input.get; | ||
| } |
There was a problem hiding this comment.
How do we handle cases where the input is not post or get? (shouldn't happen if all endpoints follow the IPAs, but it's good to handle it gracefully in case it happens)
There was a problem hiding this comment.
For now, I can edit the PR to return in all other cases. When the support for the new extension is added, the logic for extracting the operationID will have to change to support all types of endpoints (ie: non-legacy, non-custom section of anticipated corrections)
There was a problem hiding this comment.
We can also consider to handle the list cases in the list rule, the get in the get rule etc. to keep the rules specific to the different methods
TY!
lovisaberggren
approved these changes
Jul 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Added a validation function, tests, and yamls for custom methods that use :action notation. Rules and tests are not enabled at this time (this will happen in CLOUDP-329722). This function will be extended to support an extension for legacy custom methods in following PR (CLOUDP-306294)
Jira ticket: CLOUDP-328960
For more details see the Technical Design