feat(ipa): enable OperationID Validation with warning severity #871
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
August 6, 2025 10:57
wtrocki
reviewed
Aug 6, 2025
wtrocki
reviewed
Aug 6, 2025
| "license": "Apache-2.0", | ||
| "author": "MongoDB", | ||
| "main": "ipa-spectral.yaml", | ||
| "type": "module", |
There was a problem hiding this comment.
I got this error when regenerating the ReadMe
(node:58114) [MODULE_TYPELESS_PACKAGE_JSON] Warning: Module type of file:///Users/sophia.terry/openapi/tools/spectral/ipa/scripts/generateRulesetReadme.js is not specified and it doesn't parse as CommonJS.
Reparsing as ES module because module syntax was detected. This incurs a performance overhead.
To eliminate this warning, add "type": "module" to /Users/sophia.terry/openapi/tools/spectral/ipa/package.json.
(Use `node --trace-warnings ...` to show where the warning was created)
No impact on the package configuration that I know of
There was a problem hiding this comment.
Yes. We use ES format instead of commonjs.
There was a problem hiding this comment.
Feel free to create separate/small PRs for the changes like those in future.
wtrocki
approved these changes
Aug 6, 2025
|
Great to see this landing 🥇 |
wtrocki
approved these changes
Aug 6, 2025
There was a problem hiding this comment.
Could you add some test cases for:
- Valid/invalid op ID overrides for the different methods
- Usage of the verb override in standard and legacy custom methods
There was a problem hiding this comment.
Added, TY - anything missing ?
Co-authored-by: Lovisa Berggren <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
The next PR on this ticket will be in MMS, updating the OpenAPI sha to this commit. A message will be sent to MMS developers beforehand. These rules are still on warning severity and will not impact anything until they are set to error.
Jira ticket: CLOUDP-329722