feat(ipa): error on unneeded exceptions IPA 117-126 #881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lovisaberggren
commented
Aug 12, 2025
|
|
||
| if (hasException(propertyObject, RULE_NAME)) { | ||
| collectException(propertyObject, RULE_NAME, path); | ||
| if (!inputIsCloudProviderField(fieldType, input, propertyObject, propertyNameToLookFor, cloudProviderEnumValues)) { |
There was a problem hiding this comment.
Did some refactoring splitting the old function checkViolationsAndReturnErrors() into two:
- First check if the field is a cloud provider field
inputIsCloudProviderField(), if not just return - Do the validation
checkViolationsAndReturnErrors()(a bit simpler since we now know the property is considered a cloud provider field)
lovisaberggren
commented
Aug 12, 2025
There was a problem hiding this comment.
Made the helper functions private since they're only used by the new helper functions now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Updates IPA 117-126 to use the new adoption/violation/exception handler so we can fail for unneeded exceptions.
Also updated the contributing guide with the new helper functions and examples. + some code refactoring.
Jira ticket: CLOUDP-307585
Will follow up with PR to release new IPA validation version.