ci(ipa): use release tags for IPA ruleset #889
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lovisaberggren
commented
Aug 13, 2025
| echo "Changelog diff: ${diff_changelog}" | ||
| if [[ "${VERSION_BUMP}" == "false" && -n "${uncommitted_changes}" ]]; then | ||
| if [[ "${VERSION_BUMP}" == "false" && -n "${diff_changelog}" ]]; then |
There was a problem hiding this comment.
Disallow any changes to changelog if version is not bumped
lovisaberggren
commented
Aug 13, 2025
| # Check CHANGELOG.md is the generated changelog result | ||
| uncommitted_changes=$(git status --porcelain | grep "CHANGELOG.md" || echo "") | ||
|
|
||
| if [[ "${VERSION_BUMP}" == "true" && -n "${uncommitted_changes}" ]]; then |
There was a problem hiding this comment.
When version is bumped, ensure generated changelog is the same as committed
lovisaberggren
commented
Aug 13, 2025
Comment on lines
+39
to
+46
| "package": true, | ||
| "commitPattern": "[a-z]+\\(ipa\\):", | ||
| "startingVersion" : "0.0.1", | ||
| "hideCredit": true, | ||
| "tagPattern": "none", | ||
| "startingVersion": "ipa-validation-ruleset-v1.0.0", | ||
| "hideCredit": true, | ||
| "tagPattern": "ipa-validation-ruleset-v\\d+\\.\\d+\\.\\d+", | ||
| "tagPrefix": "ipa-validation-ruleset-v", | ||
| "hideEmptyReleases" : true, | ||
| "contributors": false, | ||
| "changeCount": 0 | ||
| "contributors": false |
There was a problem hiding this comment.
Adjust to use tag prefix for changelog
matt-condon
approved these changes
Aug 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
In the IPA release workflow, adding a step to create a release tag for the latest commit. The release tag follows the pattern
ipa-validation-ruleset-vX.X.Xto distinguish from the FOAS CLI release tags.These tags can then be used in the changelog generation to be able to parse which commits are included in which release.
Changes:
Added tag retroactively to first IPA release: https://github.com/mongodb/openapi/releases/tag/ipa-validation-ruleset-v0.0.1
Tested changelog with temporary tag on this branch.
Jira ticket: CLOUDP-337866