feat(ipa): new IPA rule xgen-IPA-125-discriminator-must-accompany-oneOf-anyOf-allOf #893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lovisaberggren
changed the title
| }, | ||
| oneOf: [{}], | ||
| }, | ||
| SchemaAnuOf: { |
There was a problem hiding this comment.
[nit] SchemaAnyOf
| return evaluateAndCollectAdoptionStatus(errors, rule.name, siblings, path); | ||
| }; | ||
|
|
||
| function checkViolationsAndReturnErrors(input, path, siblingKeys) { |
There was a problem hiding this comment.
Which Swagger component annotation level are we able to define exceptions? Is it Schema?
Should we update the component level for metrics collection?
There was a problem hiding this comment.
Yes, the schema. The exceptions are siblings to the discriminator since discriminators cannot have extensions.
Now the metric path is ['components', 'schemas', 'SchemaName', 'discriminator'] - no strong opinion to have it or remove the discriminator
There was a problem hiding this comment.
I think we can remove the discriminator
wtrocki
approved these changes
Aug 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
New IPA rule validates that a
discriminatorproperty is always accompanied byoneOf,allOforanyOf.Note: The exception level is on the schema itself, since we can't put extensions on the discriminator object.
Current violations: 23. Will add exceptions/corrections in follow-up
Jira ticket: CLOUDP-308542