ci(ipa): automatic warning-level violation detection #905
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| fi | ||
|
|
||
| # Create detailed description | ||
| DESCRIPTION="Warning-level violations were found during IPA validation. Please review and add exceptions if valid, or address false positives. |
There was a problem hiding this comment.
Maybe we can link to the IPA wiki with the rollout process?
There was a problem hiding this comment.
Added! Let me know how it sounds
Comment on lines
75
to
76
| chmod +x .github/scripts/handle_warning_violations.sh | ||
| .github/scripts/handle_warning_violations.sh "$WARNING_COUNT" "$TEAM_ID" "$JIRA_API_TOKEN" "$SLACK_BEARER_TOKEN" "$SLACK_CHANNEL_ID" "$SLACK_ONCALL_USER" |
There was a problem hiding this comment.
Q: Do we need the chmod +x?
There was a problem hiding this comment.
We might not need it, because I will already commit the execute permission. Let me remove and try that way
lovisaberggren
approved these changes
Aug 20, 2025
|
@lovisaberggren I commented out the "handle warning violations step" and we can turn it on when it is ready to use. Wdyt? I don’t think filtering and creating files will add much overhead |
|
SGTM! Can you create a ticket for enabling? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Jira ticket: CLOUDP-310539
This PR introduces automatic warning-level violation detection:
Would create Jira ticket with:
Would send Slack message:
Checklist
Changes to Spectral
Further comments