Specify that CSOT prose test 11 only runs on standalone servers #1672
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
There was a problem hiding this comment.
The equivalent prose test for insertMany has the following language:
This test MUST only run against standalones on server versions 4.4 and higher. The insertMany call takes an exceedingly long time on replicasets and sharded clusters. Drivers MAY adjust the timeouts used in this test to allow for differing bulk encoding performance.
Does running this test only on standalones eliminate the flakiness? If so, I suggest adding this language to the bulk write test rather than adding a test-only internal option.
baileympearson
force-pushed
the
baileympearson-patch-1
branch
from
d0bef83 to
ec937ff
Compare
isabelatkinson
approved these changes
Oct 9, 2024
|
|
||
| This test MUST only run against server versions 8.0+. This test must be skipped on Atlas Serverless. | ||
|
|
||
| This test MUST only run against standalones on server versions 4.4 and higher. The insertMany call takes an exceedingly |
There was a problem hiding this comment.
Suggested change
| This test MUST only run against standalones on server versions 4.4 and higher. The insertMany call takes an exceedingly | |
| This test MUST only run against standalones. The `bulkWrite` call takes an exceedingly |
server version requirement is already listed above
kevinAlbs
approved these changes
Oct 9, 2024
baileympearson
changed the title
prestonvasquez
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR restricts CSOT prose test 11 to only run on standalone servers.
Tests passing in Node's implementation: https://spruce.mongodb.com/version/67056335720d470007b68379/tasks?page=0&sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC&taskName=8.0
Node's implementation includes the changes in this PR.