DRIVERS-2830 - Record both FaaS and container metadata when both are present #1673
Conversation
| @@ -327,6 +327,8 @@ Depending on which `client.env.name` has been selected, other FaaS fields in `cl | |||
| Missing variables or variables with values not matching the expected type MUST cause the corresponding `client.env` | |||
| field to be omitted and MUST NOT cause a user-visible error. | |||
|
|
|||
| If any fields of `client.env.container` are populated, all FaaS values MUST be entirely omitted. | |||
There was a problem hiding this comment.
What about cases where a container is deployed on AWS Lambda? https://docs.aws.amazon.com/lambda/latest/dg/images-create.html
Wouldn't we want to include both in that case?
IIRC the issue that motivated this drivers ticket was a customer was not using Lambda but lambda still showed up in the client metadata. It looks like they were using pymongo 4.6.0. We added container detection in pymongo 4.7: PYTHON-3837.
| @@ -511,6 +511,16 @@ the following sets of environment variables: | |||
| | -------------------- | ----- | | |||
| | `AWS_EXECUTION_ENV` | `EC2` | | |||
|
|
|||
| 9. Valid container and FaaS provider. This test MUST verify that both the container metadata and the AWS Lambda metadata | |||
There was a problem hiding this comment.
We should include a note about this behavior in the client.env description above as well.
|
Perhaps update that link to https://en.wikipedia.org/wiki/Balls_into_bins_problem? |
|
Sorry, I was OOO last week when the review was requested. Changes look ok although it looks like there are some linting failures. |
Temporarily dead link, resolved itself. |
|
Please update the PR title and Jira ticket title to reflect the actual change before merging. |
NoahStapp
changed the title
DRIVERS-2830 Summary of changes:
Python implementation: mongodb/mongo-python-driver#1908.