Skip to content

DRIVERS-3023 Add spec tests for GridFS rename and require client errors #1700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 31, 2024
Merged

DRIVERS-3023 Add spec tests for GridFS rename and require client errors #1700

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
901d1e7
DRIVERS-3023 Add spec tests for GridFS rename
GromNaN Oct 30, 2024
d9feba5
Use isClientError for all GridFS errors
GromNaN Oct 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions source/gridfs/tests/delete.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions source/gridfs/tests/delete.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ tests:
object: *bucket0
arguments:
id: { $oid: "000000000000000000000000" }
expectError: { isError: true } # FileNotFound
expectError: { isClientError: true } # FileNotFound
outcome:
- collectionName: *bucket0_files_collectionName
databaseName: *database0Name
Expand Down Expand Up @@ -170,7 +170,7 @@ tests:
object: *bucket0
arguments:
id: { $oid: "000000000000000000000004" }
expectError: { isError: true } # FileNotFound
expectError: { isClientError: true } # FileNotFound
outcome:
- collectionName: *bucket0_files_collectionName
databaseName: *database0Name
Expand Down
10 changes: 5 additions & 5 deletions source/gridfs/tests/download.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions source/gridfs/tests/download.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ tests:
object: *bucket0
arguments:
id: { $oid: "000000000000000000000000" }
expectError: { isError: true } # FileNotFound
expectError: { isClientError: true } # FileNotFound
- description: "download when an intermediate chunk is missing"
operations:
- name: deleteOne
Expand All @@ -154,7 +154,7 @@ tests:
object: *bucket0
arguments:
id: { $oid: "000000000000000000000005" }
expectError: { isError: true } # ChunkIsMissing
expectError: { isClientError: true } # ChunkIsMissing
- description: "download when final chunk is missing"
operations:
- name: deleteOne
Expand All @@ -169,7 +169,7 @@ tests:
object: *bucket0
arguments:
id: { $oid: "000000000000000000000005" }
expectError: { isError: true } # ChunkIsMissing
expectError: { isClientError: true } # ChunkIsMissing
- description: "download when an intermediate chunk is the wrong size"
operations:
- name: bulkWrite
Expand All @@ -195,7 +195,7 @@ tests:
object: *bucket0
arguments:
id: { $oid: "000000000000000000000005" }
expectError: { isError: true } # ChunkIsWrongSize
expectError: { isClientError: true } # ChunkIsWrongSize
- description: "download when final chunk is the wrong size"
operations:
- name: updateOne
Expand All @@ -213,7 +213,7 @@ tests:
object: *bucket0
arguments:
id: { $oid: "000000000000000000000005" }
expectError: { isError: true } # ChunkIsWrongSize
expectError: { isClientError: true } # ChunkIsWrongSize
- description: "download legacy file with no name"
operations:
- name: download
Expand Down
4 changes: 2 additions & 2 deletions source/gridfs/tests/downloadByName.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions source/gridfs/tests/downloadByName.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,12 +133,12 @@ tests:
object: *bucket0
arguments:
filename: "xyz"
expectError: { isError: true } # FileNotFound
expectError: { isClientError: true } # FileNotFound
- description: "downloadByName when revision does not exist"
operations:
- name: downloadByName
object: *bucket0
arguments:
filename: "abc"
revision: 999
expectError: { isError: true } # RevisionNotFound
expectError: { isClientError: true } # RevisionNotFound
179 changes: 179 additions & 0 deletions source/gridfs/tests/rename.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading