Skip to content

DRIVERS-2888 Support QE with Client.bulkWrite #1770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 26 commits into
base: master
Choose a base branch
from
+497 −19
Open

DRIVERS-2888 Support QE with Client.bulkWrite #1770

Show file tree
Hide file tree
Changes from 15 commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
c6f645d
add qe to unified tests
mdb-ad Jan 23, 2025
aa51fc3
move encryptedFields to initialData
mdb-ad Feb 6, 2025
fe8ed1c
Apply suggestions from code review
mdb-ad Feb 7, 2025
44d883c
poc test feedback
mdb-ad Feb 12, 2025
ad2fd55
make keyVaultNamespace required
mdb-ad Feb 12, 2025
573aac1
remaining auto encrypt options
mdb-ad Feb 12, 2025
112d5bd
simple schema for schemaMap and encryptedFieldsMap
mdb-ad Feb 13, 2025
f910f65
convert localSchema.yml
mdb-ad Feb 14, 2025
364eb4c
convert fle2v2-EncryptedFields-vs-EncryptedFieldsMap
mdb-ad Feb 15, 2025
01505fc
document auto encrypt fields
mdb-ad Feb 15, 2025
87d3c41
client bulkWrite test
mdb-ad Feb 24, 2025
7f4021a
Merge branch 'master' into bulkwrite-qe
mdb-ad Mar 17, 2025
bd7a0fc
keyvault namespace
mdb-ad Apr 18, 2025
b2893e7
use unencrypted client to check collection contents
mdb-ad Apr 24, 2025
28b2ced
remove bulkWrite QE error
mdb-ad Apr 24, 2025
6415c1a
add csfle requirement to test
mdb-ad Jul 17, 2025
a388a7e
bulkWrite prose tests
mdb-ad Jul 23, 2025
148ed07
errorContains in test
mdb-ad Jul 23, 2025
10d34d7
tests draft
mdb-ad Aug 6, 2025
f85e42e
add limits-qe-doc
mdb-ad Aug 7, 2025
6a0daee
note server 8.0 requirement
mdb-ad Aug 14, 2025
90b3701
add limits-encryptedFields
mdb-ad Aug 14, 2025
c046c98
add language for auto-encryption to bulk write spec
isabelatkinson Aug 11, 2025
175096a
Merge branch 'master' into bulkwrite-qe
mdb-ad Aug 14, 2025
c6ca35a
Merge branch 'master' into bulkwrite-qe
mdb-ad Aug 14, 2025
0f4e11e
format
mdb-ad Aug 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions source/crud/bulk-write.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -634,13 +634,6 @@ write concern containing the following message:

> Cannot request unacknowledged write concern and ordered writes

## Auto-Encryption

If `MongoClient.bulkWrite` is called on a `MongoClient` configured with `AutoEncryptionOpts`, drivers MUST return an
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove prose test 13 (expects an error) in the CRUD tests: https://github.com/mongodb/specifications/blob/0f4e11e78f50cf7f4dd167d5ba37a519dd8164f5/source/crud/tests/README.md#13-mongoclientbulkwrite-returns-an-error-if-auto-encryption-is-configured

error with the message: "bulkWrite does not currently support automatic encryption".

This is expected to be removed once [DRIVERS-2888](https://jira.mongodb.org/browse/DRIVERS-2888) is implemented.

## Command Batching

Drivers MUST accept an arbitrary number of operations as input to the `MongoClient.bulkWrite` method. Because the server
Expand Down Expand Up @@ -917,6 +910,8 @@ error in this specific situation does not seem helpful enough to require size ch

## **Changelog**

- 2025-04-23: Removed the requirement to error when QE is enabled.

- 2024-11-05: Updated the requirements regarding the size validation.

- 2024-10-07: Error if `w:0` is used with `ordered=true` or `verboseResults=true`.
Expand Down
296 changes: 296 additions & 0 deletions source/crud/tests/unified/client-bulkWrite-qe.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading