Skip to content

DRIVERS-3213 add text search explicit encryption API and tests #1824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
Aug 13, 2025

Conversation

mdb-ad
Copy link
Contributor

@mdb-ad mdb-ad commented Aug 6, 2025

Summary

  • Add explicit encryption API of Queryable Encryption (QE) text indexes added in SPM-4158.
  • Add prose tests.

Background & Motivation

libmongocrypt

Driver bindings to libmongocrypt will need to pass explicit options through the new helper added in 1.15.0: mongocrypt_ctx_setopt_algorithm_text. Tests require libmongocrypt 1.15.1. MONGOCRYPT-828 (in 1.15.1) is needed to pass Case 7.

TextOpts

The structure of TextOpts resembles the placeholder created by query analysis (mongocryptd/crypt_shared): FLE2TextSearchInsertSpec. The repeated parameters (e.g. suffix.strMaxQueryLength and prefix.strMaxQueryLength) are to support a field with both prefix and suffix queries with different values.


Please complete the following before merging:

  • Update changelog.
  • Test changes in at least one language driver.
  • Test these changes against all server versions and topologies (including standalone, replica set, and sharded
    clusters).

C driver implementation: https://spruce.mongodb.com/version/6894132fba56770007851f12

@mdb-ad mdb-ad changed the title Text search explicit encryption prose tests DRIVERS-3227 Text search explicit encryption prose tests Aug 7, 2025
@mdb-ad mdb-ad marked this pull request as ready for review August 7, 2025 03:31
@mdb-ad mdb-ad requested a review from a team as a code owner August 7, 2025 03:31
@mdb-ad mdb-ad requested review from katcharov and removed request for a team August 7, 2025 03:31
@kevinAlbs kevinAlbs requested review from kevinAlbs and removed request for katcharov August 7, 2025 11:48
@kevinAlbs kevinAlbs changed the title DRIVERS-3227 Text search explicit encryption prose tests DRIVERS-3213 add text search explicit encryption API and tests Aug 7, 2025
@kevinAlbs kevinAlbs requested review from rozza and removed request for rozza August 8, 2025 15:38
@mdb-ad mdb-ad force-pushed the text-search branch 2 times, most recently from 99ce95a to 223e65e Compare August 11, 2025 19:59
Copy link
Contributor

@kevinAlbs kevinAlbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks close. Suggested an added test for 1.15.1 and test structure changes.

@mdb-ad mdb-ad requested a review from kevinAlbs August 12, 2025 19:32
Copy link
Contributor

@baileympearson baileympearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mdb-ad mdb-ad requested a review from baileympearson August 12, 2025 22:04
@mdb-ad mdb-ad merged commit 25ebca1 into mongodb:master Aug 13, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants