-
Notifications
You must be signed in to change notification settings - Fork 245
DRIVERS-3213 add text search explicit encryption API and tests #1824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no query type "textPreview". Use more generic term.
kevinAlbs
reviewed
Aug 7, 2025
kevinAlbs
reviewed
Aug 7, 2025
baileympearson
requested changes
Aug 8, 2025
source/client-side-encryption/etc/data/encryptedFields-prefix-suffix.json
Outdated
Show resolved
Hide resolved
source/client-side-encryption/etc/data/encryptedFields-substring.json
Outdated
Show resolved
Hide resolved
99ce95a
to
223e65e
Compare
kevinAlbs
reviewed
Aug 11, 2025
kevinAlbs
reviewed
Aug 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks close. Suggested an added test for 1.15.1 and test structure changes.
Co-authored-by: Kevin Albertson <[email protected]>
kevinAlbs
approved these changes
Aug 12, 2025
baileympearson
requested changes
Aug 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
baileympearson
approved these changes
Aug 12, 2025
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Background & Motivation
libmongocrypt
Driver bindings to libmongocrypt will need to pass explicit options through the new helper added in 1.15.0:
mongocrypt_ctx_setopt_algorithm_text
. Tests require libmongocrypt 1.15.1. MONGOCRYPT-828 (in 1.15.1) is needed to passCase 7
.TextOpts
The structure of TextOpts resembles the placeholder created by query analysis (mongocryptd/crypt_shared): FLE2TextSearchInsertSpec. The repeated parameters (e.g.
suffix.strMaxQueryLength
andprefix.strMaxQueryLength
) are to support a field with both prefix and suffix queries with different values.Please complete the following before merging:
clusters).
C driver implementation: https://spruce.mongodb.com/version/6894132fba56770007851f12