DRIVERS-719 OpenTelementry specification #1826

nhachicha · 2025-08-08T16:04:07Z

Update schema to 1.26
Added invalid test to unified test runner
Added nominal valid tests for the 3 tracing grouping (Operation, Cursor and Transaction)
Update description of the new field observeTracingMessages and expectTracingMessages
Merge back the draft spec into this

…logy. Adding toplogy requirements for transaction tests

GromNaN · 2025-08-08T17:31:49Z

source/open-telemetry/open-telemetry.md

+- `driver_operation_name db.collection_name` if the command is executed on a collection (e.g.,
+    `findOneAndDelete warehouse.users`).
+- `db.driver_operation_name` if there is no specific collection for the command (e.g., `warehouse.runCommand`).


This looks inconsistent. Why the driver_operation_name is at the beginning for a collection operation and at the end for a database operation?

One of this would be more consistent:

warehouse.users.findOneAndDelete and warehouse.runCommand

findOneAndDelete warehouse.users and runCommand warehouse

The naming follows the design document. We can revisit though 👍 https://docs.google.com/document/d/1182STFDVkQ6ixy1iCWZROC5K-Ef4M3aV__5--WXB7DI/edit?tab=t.0#heading=h.2s9zdv6a57gn

@GromNaN: Note the same inconsistency exists in the Instrumenting Server Commands > Span Name section below. I'd be in favor of using the operation/command name as the initial prefix and then appending the database or full namespace as appropriate.

GromNaN · 2025-08-08T17:39:10Z

source/open-telemetry/open-telemetry.md

+
+Spans SHOULD have the following attributes:
+
+| Attribute              | Type     | Description                                                                | Requirement Level     |


db.client.connection.pool.name is not listed. Is it because it doesn't have the "stable" flag? It would be easy to fill when the connection is created by an ODM, they usually have a connection name.

source/open-telemetry/open-telemetry.md

jmikola · 2025-08-13T23:49:42Z

source/open-telemetry/open-telemetry.md

+- `driver_operation_name db.collection_name` if the command is executed on a collection (e.g.,
+    `findOneAndDelete warehouse.users`).
+- `db.driver_operation_name` if there is no specific collection for the command (e.g., `warehouse.runCommand`).


@GromNaN: Note the same inconsistency exists in the Instrumenting Server Commands > Span Name section below. I'd be in favor of using the operation/command name as the initial prefix and then appending the database or full namespace as appropriate.

source/open-telemetry/open-telemetry.md

source/unified-test-format/tests/invalid/expectedTracingSpans-spanMalformedMissingName.yml

source/unified-test-format/tests/invalid/expectedTracingSpans-spanMalformedTagsMustBeObject.yml

jmikola · 2025-08-14T00:34:23Z

source/unified-test-format/unified-test-format.md

+        - `enableCommandPayload`: Optional boolean. When set to `true`, enables capturing of command payload details in
+            tracing spans.
+            - If `true`, the test runner SHOULD capture detailed command payload information in tracing spans.
+            - If `false` or omitted, the test runner SHOULD exclude command payload details.


I realize this impacts the test runner, but should it also refer to configuring the MongoClient to enable tracing?

Co-authored-by: Jeremy Mikola <[email protected]>

…TracingMessages-additionalProperties.yml Co-authored-by: Jeremy Mikola <[email protected]>

…spanMalformedTagsMustBeObject.yml Co-authored-by: Jeremy Mikola <[email protected]>

…TracingMessages-additionalPropertyType.yml Co-authored-by: Jeremy Mikola <[email protected]>

…missingPropertySpans.yml Co-authored-by: Jeremy Mikola <[email protected]>

…spanMalformedMissingName.yml Co-authored-by: Jeremy Mikola <[email protected]>

…spanMalformedTagsMustBeObject.yml Co-authored-by: Jeremy Mikola <[email protected]>

…spanMalformedAdditionalProperties.yml Co-authored-by: Jeremy Mikola <[email protected]>

…spanMalformedNestedMustBeArray.yml Co-authored-by: Jeremy Mikola <[email protected]>

…spanMalformedMissingName.yml Co-authored-by: Jeremy Mikola <[email protected]>

…spanMalformedMissingTags.yml Co-authored-by: Jeremy Mikola <[email protected]>

Co-authored-by: Jeremy Mikola <[email protected]>

nhachicha added 5 commits July 11, 2025 18:57

added first tracing tests

97d8a5b

using unsetOrMatches for txNumber, since it's not set for single topo…

c82a6a2

…logy. Adding toplogy requirements for transaction tests

updating tests

61270d6

Tests and schema update for the upcoming Otel spec

581faa1

Merge branch 'nh/tracing'

c447d10

nhachicha self-assigned this Aug 8, 2025

nhachicha and others added 5 commits August 8, 2025 16:05

Update generated files

3a578ee

update schema to latest (1.26)

dbb1a9c

update tests

29e25a1

DRIVERS-719 OpenTelementry specification

f801d78

Cursor operations

9d66a8a

nhachicha changed the title ~~OpenTelemetry~~ DRIVERS-719 OpenTelementry specification Aug 8, 2025

nhachicha assigned comandeo-mongo Aug 8, 2025

nhachicha mentioned this pull request Aug 8, 2025

DRIVERS-719 OpenTelementry specification #1821

Closed

3 tasks

GromNaN reviewed Aug 8, 2025

View reviewed changes

nhachicha added 6 commits August 9, 2025 16:54

update doc

269221c

moved tests under open-telemtry directroy

452696d

Fixing formatting

9f05c59

update formatting using pre-commit mdformat

0523751

Adding Test README

8466c1b

Adding retries test, fixing duplicate exception tag

18ad723

jmikola reviewed Aug 14, 2025

View reviewed changes

nhachicha and others added 8 commits August 14, 2025 17:48

Update source/open-telemetry/open-telemetry.md

04b947a

Co-authored-by: Jeremy Mikola <[email protected]>

Update source/open-telemetry/open-telemetry.md

88c7be0

Co-authored-by: Jeremy Mikola <[email protected]>

Update source/unified-test-format/tests/invalid/entity-client-observe…

ced82eb

…TracingMessages-additionalProperties.yml Co-authored-by: Jeremy Mikola <[email protected]>

Update source/unified-test-format/tests/invalid/expectedTracingSpans-…

f1804c3

…spanMalformedTagsMustBeObject.yml Co-authored-by: Jeremy Mikola <[email protected]>

Update source/unified-test-format/tests/invalid/entity-client-observe…

03d4e3c

…TracingMessages-additionalPropertyType.yml Co-authored-by: Jeremy Mikola <[email protected]>

Update source/unified-test-format/tests/invalid/expectedTracingSpans-…

3c69ed5

…missingPropertySpans.yml Co-authored-by: Jeremy Mikola <[email protected]>

Update source/unified-test-format/tests/invalid/expectedTracingSpans-…

240d009

…spanMalformedMissingName.yml Co-authored-by: Jeremy Mikola <[email protected]>

Update source/unified-test-format/tests/invalid/expectedTracingSpans-…

6a4d217

…spanMalformedTagsMustBeObject.yml Co-authored-by: Jeremy Mikola <[email protected]>

nhachicha and others added 10 commits August 15, 2025 10:25

Update generated files

b596f05

Update source/unified-test-format/tests/invalid/expectedTracingSpans-…

bbb075b

…spanMalformedAdditionalProperties.yml Co-authored-by: Jeremy Mikola <[email protected]>

Update source/unified-test-format/tests/invalid/expectedTracingSpans-…

a5638da

…spanMalformedNestedMustBeArray.yml Co-authored-by: Jeremy Mikola <[email protected]>

Update source/unified-test-format/tests/invalid/expectedTracingSpans-…

56570a5

…spanMalformedMissingName.yml Co-authored-by: Jeremy Mikola <[email protected]>

Update source/unified-test-format/tests/invalid/expectedTracingSpans-…

a4aa513

…spanMalformedMissingTags.yml Co-authored-by: Jeremy Mikola <[email protected]>

Using YAML anchors and references

cb74b54

PR feedback: Updating schema, adding more invalid tests

3caa87f

Fixing lint errors

7a68cbc

Update source/open-telemetry/open-telemetry.md

1c24759

Co-authored-by: Jeremy Mikola <[email protected]>

Update source/open-telemetry/open-telemetry.md

a989a49

Co-authored-by: Jeremy Mikola <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

DRIVERS-719 OpenTelementry specification #1826

DRIVERS-719 OpenTelementry specification #1826

nhachicha commented Aug 8, 2025 •

edited

Loading

Uh oh!

GromNaN Aug 8, 2025

Uh oh!

nhachicha Aug 8, 2025

Uh oh!

jmikola Aug 13, 2025

Uh oh!

GromNaN Aug 8, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jmikola Aug 13, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jmikola Aug 14, 2025

Uh oh!

Uh oh!


		Spans SHOULD have the following attributes:

		\| Attribute \| Type \| Description \| Requirement Level \|

DRIVERS-719 OpenTelementry specification #1826

Are you sure you want to change the base?

DRIVERS-719 OpenTelementry specification #1826

Conversation

nhachicha commented Aug 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

GromNaN Aug 8, 2025

Choose a reason for hiding this comment

Uh oh!

nhachicha Aug 8, 2025

Choose a reason for hiding this comment

Uh oh!

jmikola Aug 13, 2025

Choose a reason for hiding this comment

Uh oh!

GromNaN Aug 8, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jmikola Aug 13, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jmikola Aug 14, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

nhachicha commented Aug 8, 2025 •

edited

Loading