-
Notifications
You must be signed in to change notification settings - Fork 246
DRIVERS-3207: Custom AWS credential providers execute earlier #1838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
174d5cb
to
b2ae9b3
Compare
baileympearson
previously requested changes
Sep 10, 2025
dariakp
requested changes
Sep 10, 2025
I have added a prose test for FLE in case 26. Case 15 I don't believe is relevant as it pertains to automatic credential fetching, which means nothing is provided. Even with the changes in this PR the order on automatic credential fetching is the same. |
Added link. |
dariakp
requested changes
Sep 15, 2025
blink1073
approved these changes
Sep 15, 2025
katcharov
reviewed
Sep 16, 2025
blink1073
approved these changes
Sep 17, 2025
kevinAlbs
reviewed
Sep 17, 2025
Co-authored-by: Kevin Albertson <[email protected]>
7fb8cf8
to
ed72b63
Compare
kevinAlbs
approved these changes
Sep 17, 2025
katcharov
approved these changes
Sep 18, 2025
dariakp
approved these changes
Sep 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the AWS auth spec to require drivers that implement custom AWS credential providers to use the custom provider before any other method.
Updates test wording to include the extra scenario for testing a custom provider when explicit credentials are also provided.
Node implementation: mongodb/node-mongodb-native#4656
Please complete the following before merging:
clusters).