DRIVERS-3397: Add SDAM tests for constant setVersion#1895
Merged
jyemin merged 2 commits intomongodb:masterfrom Feb 26, 2026
Merged
DRIVERS-3397: Add SDAM tests for constant setVersion#1895jyemin merged 2 commits intomongodb:masterfrom
jyemin merged 2 commits intomongodb:masterfrom
Conversation
Add server discovery and monitoring tests for replica sets that use a constant setVersion value instead of incrementing it on reconfig. This adds three test scenarios: - Primary changes with unchanged setVersion (electionId-based detection) - Migration from incrementing to constant setVersion - Migration from constant to incrementing setVersion These tests validate that drivers correctly handle primary staleness detection when setVersion remains constant across topology changes.
XueruiFa
reviewed
Feb 13, 2026
XueruiFa
left a comment
XueruiFa
left a comment
There was a problem hiding this comment.
Thanks very much for adding these tests!
| @@ -0,0 +1,118 @@ | |||
| # Disaggregated storage clusters use a constant setVersion (typically 1) instead of | |||
There was a problem hiding this comment.
Would it be possible to also add a test that the member list is updated if setVersion and electionId remain the same?
Contributor
Author
There was a problem hiding this comment.
New test added. Please have a look.
ShaneHarvey
approved these changes
Feb 25, 2026
Member
ShaneHarvey
left a comment
ShaneHarvey
left a comment
There was a problem hiding this comment.
LGTM. Tests pass in pymongo locally. Running a patch here: https://spruce.corp.mongodb.com/task/mongo_python_driver_mongodb_v8.0_test_server_version_python3.12_sync_auth_nossl_standalone_patch_84814b2a7275c7f6b8b5221e1ce071b358823e06_699f79ec0acf44000793846a_26_02_25_22_39_11/logs?execution=0
Member
|
The tests pass in evergreen too. LGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add server discovery and monitoring tests for replica sets that use a constant setVersion value instead of incrementing it on reconfig.
This adds four test scenarios:
These tests validate that drivers correctly handle primary staleness detection when setVersion remains constant across topology changes.
Please complete the following before merging:
clusters). N/A as these are unit tests.