Skip to content

chore: Upgrades golangci-lint to v2 #3224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 28, 2025
Merged

chore: Upgrades golangci-lint to v2 #3224

merged 6 commits into from
Mar 28, 2025

Conversation

lantoli
Copy link
Member

@lantoli lantoli commented Mar 28, 2025 •
edited
Loading

Description

Upgrades golangci-lint to v2 using the migration guide, follow example in: mongodb/openapi#616

Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR. A migration guide must be created or updated if the new feature will go in a major version.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR. A migration guide must be created or updated.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contributing guides
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals I have added appropriate changelog entries.
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

lantoli
lantoli commented Mar 28, 2025
View reviewed changes
internal/common/conversion/collections_test.go
} else {
assert.NotNil(t, ret)
assert.Equal(t, len(*value), len(*ret))
assert.Len(t, *value, len(*ret))
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixes: len: use assert.Len (testifylint)

lantoli
lantoli commented Mar 28, 2025
View reviewed changes
internal/common/conversion/type_conversion_test.go
assert.Equal(t, 0, conversion.SafeValue(intPointer))
var stringPointer *string
assert.Equal(t, "", conversion.SafeValue(stringPointer))
assert.Empty(t, conversion.SafeValue(stringPointer))
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixes: empty: use assert.NotEmpty (testifylint)

lantoli
lantoli commented Mar 28, 2025
View reviewed changes
internal/service/cloudbackupsnapshotrestorejob/resource_cloud_backup_snapshot_restore_job.go
isOpIncSet := oplogIncOk && oplogInc != nil && (oplogInc.(int) > 0)

if !isPITSet && !(isOpTSSet && isOpIncSet) {
if !isPITSet && (!isOpTSSet || !isOpIncSet) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixes: QF1001: could apply De Morgan's law (staticcheck)

@lantoli lantoli marked this pull request as ready for review March 28, 2025 10:23
@lantoli lantoli requested a review from a team as a code owner March 28, 2025 10:23
andreaangiolillo
andreaangiolillo approved these changes Mar 28, 2025
View reviewed changes
Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lantoli lantoli merged commit 47e5b7e into master Mar 28, 2025
51 of 52 checks passed
@lantoli lantoli deleted the go_lint_v2 branch March 28, 2025 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andreaangiolillo andreaangiolillo andreaangiolillo approved these changes

@EspenAlbert EspenAlbert EspenAlbert approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lantoli @andreaangiolillo @EspenAlbert