Skip to content

feat: Add new singular data source mongodbatlas_cloud_user_project_assignment #3569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 15 commits into
base: CLOUDP-333176
Choose a base branch
from

Conversation

csanx
Copy link
Collaborator

@csanx csanx commented Aug 7, 2025

Description

Add new singular data source: mongodbatlas_cloud_user_project_assignment

Link to any related issue(s): CLOUDP-333177

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR. A migration guide must be created or updated if the new feature will go in a major version.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR. A migration guide must be created or updated.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contributing guides
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals I have added appropriate changelog entries.
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

@csanx csanx changed the base branch from master to CLOUDP-333176 August 7, 2025 12:42
@csanx csanx marked this pull request as ready for review August 11, 2025 08:00
@csanx csanx requested review from a team as code owners August 11, 2025 08:00
Copy link
Contributor

APIx bot: a message has been sent to Docs Slack channel

}
extraChecks := []resource.TestCheckFunc{
resource.TestCheckResourceAttr(DSNameUserID, "username", username),
resource.TestCheckResourceAttrPair(DSNameUsername, "user_id", DSNameUserID, "user_id"),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should it be the same check for username above?

userID := state.UserId.ValueString()
username := state.Username.ValueString()

if username == "" && userID == "" {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we have a test to validate this error as well?

@@ -128,7 +128,7 @@ func removeProjectInvitationConfigThird(username, projectName, orgID string, rol
`, username, rolesStr, projectName, orgID)
}

func checksSecond(username, projectName string, roles []string) resource.TestCheckFunc {
func checksSecond(username string, roles []string) resource.TestCheckFunc {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are we managing the project as part of this test?
Can we not use ProjectIDExecution?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants