feat: Add new singular data source mongodbatlas_cloud_user_project_assignment #3569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
July 28, 2025 18:15
|
APIx bot: a message has been sent to Docs Slack channel |
13 tasks
marcosuma
approved these changes
Aug 11, 2025
maastha
reviewed
Aug 11, 2025
maastha
reviewed
Aug 11, 2025
jwilliams-mongo
approved these changes
Aug 11, 2025
EspenAlbert
reviewed
Aug 12, 2025
| @@ -128,7 +128,7 @@ func removeProjectInvitationConfigThird(username, projectName, orgID string, rol | |||
| `, username, rolesStr, projectName, orgID) | |||
| } | |||
|
|
|||
| func checksSecond(username, projectName string, roles []string) resource.TestCheckFunc { | |||
| func checksSecond(username string, roles []string) resource.TestCheckFunc { | |||
There was a problem hiding this comment.
why are we managing the project as part of this test?
Can we not use ProjectIDExecution?
There was a problem hiding this comment.
Yes we can, thanks for pointing that out! Updated it
maastha
reviewed
Aug 12, 2025
| roles = [%[5]s] | ||
| } | ||
|
|
||
| data "mongodbatlas_cloud_user_project_assignment" "testUsername" { |
There was a problem hiding this comment.
nit: stay consistent with format used for naming resources/data sources, for example, for resource you used test_active (with an _) but here uou name it testUsername (different casing).
Use one format consistently & this applies to all tests, examples, documentation etc
There was a problem hiding this comment.
Good point, changed it to be consistent
maastha
approved these changes
Aug 12, 2025
oarbusi
approved these changes
Aug 13, 2025
added 2 commits
August 13, 2025 09:53
csanx
added a commit
that referenced
this pull request
Aug 14, 2025
) * WIP- Created resource * Added model tests * Added tests * Fixed import * Typo * Preview new SDK version * WIP - Migration test * WIP - migration test * Updated SDK * Revert "Updated SDK" This reverts commit f8d2d0a. * Updated SDK * Fixed migration test * Changelog * CheckDestroy * Refactor * typo * Fix * Added TestNewAtlasUpdateReq * Empty/nil test cases * Fix * Added active user to test * Added MONGODB_ATLAS_USERNAME_2 * Changed Update to read from API * Added comment * feat: Add new singular data source mongodbatlas_cloud_user_project_assignment (#3569) * Add schema and Read() method * Add data source to provider * WIP * Tests * Changed tests * Changelog * Refactor * Typo * Fix * Updated tests * Fixed test * Added error --------- Co-authored-by: Cristina Sánchez Sánchez <[email protected]> --------- Co-authored-by: Cristina Sánchez Sánchez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add new singular data source:
mongodbatlas_cloud_user_project_assignmentLink to any related issue(s): CLOUDP-333177
Type of change:
Required Checklist:
Further comments