chore: Update to Go 1.24.6 and Go linter to 2.3.1 #3579
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
snyk false positives |
lantoli
changed the title
lantoli
commented
Aug 11, 2025
| @@ -142,7 +142,7 @@ func TestCleanProjectAndClusters(t *testing.T) { | |||
| }) | |||
| } | |||
| t.Cleanup(func() { | |||
| projectsAfter := readAllProjects(context.Background(), t, client) //nolint:usetesting // reason: using context.Background() here intentionally because t.Context() is canceled at cleanup | |||
| projectsAfter := readAllProjects(context.Background(), t, client) // reason: using context.Background() here intentionally because t.Context() is canceled at cleanup | |||
There was a problem hiding this comment.
fix linter issue:
internal/testutil/clean/org_clean_test.go:145:69: directive `//nolint:usetesting // reason: using context.Background() here intentionally because t.Context() is canceled at cleanup` is unused for linter "usetesting" (nolintlint)
lantoli
commented
Aug 11, 2025
| @@ -75,12 +76,12 @@ func writeToFile(fileName, content string) error { | |||
|
|
|||
| // formatGoFile runs goimports and fieldalignment on the specified Go file | |||
| func formatGoFile(filePath string) { | |||
| goimportsCmd := exec.Command("goimports", "-w", filePath) | |||
| goimportsCmd := exec.CommandContext(context.Background(), "goimports", "-w", filePath) | |||
There was a problem hiding this comment.
fix linter issue:
os/exec.Command must not be called. use os/exec.CommandContext (noctx)
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Go version from 1.24.5 to 1.24.6 and the golangci-lint version from 2.1.6 to 2.3.1. This is a maintenance update to keep dependencies current.
Key changes:
- Go runtime version bump to 1.24.6
- Golangci-lint version update to 2.3.1 across Makefile and GitHub Actions
- Addition of context to exec commands for better cancellation support
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| go.mod | Updates Go version from 1.24.5 to 1.24.6 |
| Makefile | Updates golangci-lint version from v2.1.6 to v2.3.1 |
| .github/workflows/code-health.yml | Updates golangci-lint action version to v2.3.1 |
| tools/codegen/main.go | Adds context support to exec commands |
| internal/testutil/clean/org_clean_test.go | Updates linter directive format |
| internal/serviceapi/projectapi/resource_schema.go | Enhances documentation for project alert settings |
| internal/serviceapi/clusterapi/resource_schema.go | Improves documentation for region configs and cluster states |
EspenAlbert
reviewed
Aug 11, 2025
| @@ -258,7 +258,7 @@ func ResourceSchema(ctx context.Context) schema.Schema { | |||
| }, | |||
| "region_configs": schema.ListNestedAttribute{ | |||
| Optional: true, | |||
| MarkdownDescription: "Hardware specifications for nodes set for a given region. Each **regionConfigs** object describes the region's priority in elections and the number and type of MongoDB nodes that MongoDB Cloud deploys to the region. Each **regionConfigs** object must have either an **analyticsSpecs** object, **electableSpecs** object, or **readOnlySpecs** object. Tenant clusters only require **electableSpecs. Dedicated** clusters can specify any of these specifications, but must have at least one **electableSpecs** object within a **replicationSpec**.\n\n**Example:**\n\nIf you set `\"replicationSpecs[n].regionConfigs[m].analyticsSpecs.instanceSize\" : \"M30\"`, set `\"replicationSpecs[n].regionConfigs[m].electableSpecs.instanceSize\" : `\"M30\"` if you have electable nodes and `\"replicationSpecs[n].regionConfigs[m].readOnlySpecs.instanceSize\" : `\"M30\"` if you have read-only nodes.", | |||
| MarkdownDescription: "Hardware specifications for nodes set for a given region. Each **regionConfigs** object must be unique by region and cloud provider within the **replicationSpec**. Each **regionConfigs** object describes the region's priority in elections and the number and type of MongoDB nodes that MongoDB Cloud deploys to the region. Each **regionConfigs** object must have either an **analyticsSpecs** object, **electableSpecs** object, or **readOnlySpecs** object. Tenant clusters only require **electableSpecs. Dedicated** clusters can specify any of these specifications, but must have at least one **electableSpecs** object within a **replicationSpec**.\n\n**Example:**\n\nIf you set `\"replicationSpecs[n].regionConfigs[m].analyticsSpecs.instanceSize\" : \"M30\"`, set `\"replicationSpecs[n].regionConfigs[m].electableSpecs.instanceSize\" : `\"M30\"` if you have electable nodes and `\"replicationSpecs[n].regionConfigs[m].readOnlySpecs.instanceSize\" : `\"M30\"` if you have read-only nodes.", | |||
There was a problem hiding this comment.
yes, the check is triggered as tool changed: https://github.com/mongodb/terraform-provider-mongodbatlas/actions/runs/16879077164/job/47810284143?pr=3579
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update to Go 1.24.6 and Go linter to 2.3.1
Link to any related issue(s):
Type of change:
Required Checklist:
Further comments