test: Updates all test workflows to use advanced_cluster TPF implementation #3580

maastha · 2025-08-11T13:17:46Z

Description

Test suite run: https://github.com/mongodb/terraform-provider-mongodbatlas/actions/runs/16890016640

This PR also addresses all remaining code changes mentioned in CLOUDP-336437

Link to any related issue(s): CLOUDP-336437

Type of change:

Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR. A migration guide must be created or updated if the new feature will go in a major version.
Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR. A migration guide must be created or updated.
This change requires a documentation update
Documentation fix/enhancement

Required Checklist:

I have signed the MongoDB CLA
I have read the contributing guides
I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
I have added any necessary documentation (if appropriate)
I have run make fmt and formatted my code
If changes include deprecations or removals I have added appropriate changelog entries.
If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

maastha · 2025-08-12T15:47:57Z

failing check is unrelated to this PR

Copilot

Pull Request Overview

This PR fixes test suite failures by addressing HCL configuration generation issues and test compatibility problems. The changes focus on correcting Terraform configuration syntax and ensuring proper test execution.

Updates HCL configuration generation to use TupleVal instead of ListVal for better type flexibility
Fixes Terraform configuration syntax in test files to use proper assignment operators
Adds version compatibility checks for migration tests

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
internal/testutil/acc/config_cluster.go	Refactors variable names, fixes indentation, and changes from ListVal to TupleVal for replication specs
internal/serviceapi/searchdeploymentapi/resource_test.go	Updates cluster configuration syntax from block to assignment format
internal/service/clusteroutagesimulation/resource_test.go	Adds blank line for import formatting
internal/service/clusteroutagesimulation/resource_migration_test.go	Adds version compatibility checks for migration tests
.github/workflows/code-health.yml	Changes reduced_tests flag to true for workflow optimization

internal/testutil/acc/config_cluster.go

EspenAlbert

~~Where did the advanced_cluster acceptance tests go? I cannot find them in the tree: internal/service/advancedcluster/resource_advanced_cluster_test.go~~ found them in resource_test in tpf package

EspenAlbert

LGTM

lantoli · 2025-08-13T09:19:06Z

.github/workflows/acceptance-tests-runner.yml

@@ -14,7 +14,7 @@ on:
        type: string
        required: false    
      test_group:
-        description: 'Test group to run, e.g. advanced_cluster, empty for all'
+        description: 'Test group to run, e.g. advanced_cluster_tpf, empty for all'


what about renaming all occurences in this file from advanced_cluster_tpf to advanced_cluster as that's the only one now?

I thought that would be done later as part of the cleanup when we finally delete advancedcluster? but no strong opinion, will update

ah, ok, the cleanup was more about the service folders but i see your point here, feel free to keep it as it is if you prefer that

updated now

lantoli · 2025-08-13T09:22:59Z

.github/workflows/acceptance-tests-runner.yml

@@ -436,7 +431,7 @@ jobs:
          MONGODB_ATLAS_LAST_1X_VERSION: ${{ inputs.mongodb_atlas_last_1x_version }}
          ACCTEST_REGEX_RUN: '^TestMig'
          ACCTEST_PACKAGES: |
-            ./internal/service/advancedcluster
+            ./internal/service/advancedclustertpf


do we still need advanced_cluster_tpf_mig_from_sdkv2 tests? Maybe we can remove it, and remove logic associated with env.var MONGODB_ATLAS_TEST_SDKV2_TO_TPF from the code.

I recommended in the team to keep these for at least a couple next releases until we have a better idea of adoption & may also help us understand if we need to handle any additional scenarios that might come up based on changes in the next releases

lantoli · 2025-08-13T09:24:47Z

internal/testutil/acc/config_cluster.go

 				}
 				rcMap["auto_scaling"] = cty.ObjectVal(map[string]cty.Value{
 					"disk_gb_enabled": cty.BoolVal(asDisk.GetEnabled()),
 				})
 			}

-			nodeSpec := rc.GetElectableSpecs()
+			es := rc.GetElectableSpecs()


are these changes related with test workflow changes?

not exactly, these were to fix one of the tests

.github/workflows/code-health.yml

marcosuma · 2025-08-13T09:59:24Z

.github/workflows/acceptance-tests-runner.yml

@@ -14,7 +14,7 @@ on:
        type: string
        required: false    
      test_group:
-        description: 'Test group to run, e.g. advanced_cluster, empty for all'
+        description: 'Test group to run, e.g. advanced_cluster_tpf, empty for all'


curious about the context: why do we still need to specify the _tpf?

i made a similar comment, we can remove tpf now that it's the only test group

lantoli · 2025-08-14T07:35:56Z

.github/workflows/acceptance-tests-runner.yml

@@ -275,9 +274,6 @@ jobs:
      with:
        filters: |
          advanced_cluster:
-            - 'internal/service/advancedcluster/!(*_test).go' # matches any adv_cluster file change except test files
-            - 'internal/service/advancedclustertpf/common*.go'
-          advanced_cluster_tpf:
            - 'internal/service/advancedclustertpf/*.go'
            - 'internal/service/advancedcluster/*_test.go'


is there any test in adv_cluster (without tpf) or we can delete filter path 'internal/service/advancedcluster/*_test.go' ?

we're only running package ./internal/service/advancedclustertpf so I think it's ok to delete the filter path

removed 'internal/service/advancedcluster/*_test.go' ty!

fix

8dd6255

maastha changed the base branch from master to CLOUDP-320243-dev-2.0.0 August 11, 2025 13:19

maastha added 4 commits August 11, 2025 19:27

fix

a9f8fb5

fix

177581e

nit

e9d1239

nit

f419e76

maastha marked this pull request as ready for review August 12, 2025 15:48

Copilot AI review requested due to automatic review settings August 12, 2025 15:48

maastha requested a review from a team as a code owner August 12, 2025 15:48

Copilot AI reviewed Aug 12, 2025

View reviewed changes

internal/testutil/acc/config_cluster.go Show resolved Hide resolved

internal/testutil/acc/config_cluster.go Show resolved Hide resolved

maastha added 4 commits August 12, 2025 23:39

init

dc53484

revert

95c3428

fmt

1062349

nit

1bf0f23

maastha changed the title ~~test: Fix test suite failures~~ test: Updates all test workflows to use advanced_cluster TPF implementation Aug 12, 2025

EspenAlbert reviewed Aug 13, 2025

View reviewed changes

EspenAlbert approved these changes Aug 13, 2025

View reviewed changes

lantoli reviewed Aug 13, 2025

View reviewed changes

marcosuma approved these changes Aug 13, 2025

View reviewed changes

nit

0bcb43e

lantoli reviewed Aug 14, 2025

View reviewed changes

lantoli approved these changes Aug 14, 2025

View reviewed changes

pr cmt

4358b36

maastha merged commit 5517239 into CLOUDP-320243-dev-2.0.0 Aug 14, 2025
43 checks passed

maastha deleted the CLOUDP-336437-fix-test-suite branch August 14, 2025 12:52

test: Updates all test workflows to use advanced_cluster TPF implementation #3580

test: Updates all test workflows to use advanced_cluster TPF implementation #3580

Uh oh!

Conversation

maastha commented Aug 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of change:

Required Checklist:

Further comments

Uh oh!

maastha commented Aug 12, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

EspenAlbert left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

EspenAlbert left a comment

Choose a reason for hiding this comment

Uh oh!

lantoli Aug 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

maastha Aug 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lantoli Aug 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

maastha commented Aug 11, 2025 •

edited

Loading

EspenAlbert left a comment •

edited

Loading

lantoli Aug 13, 2025 •

edited

Loading

maastha Aug 14, 2025 •

edited

Loading

lantoli Aug 14, 2025 •

edited

Loading