Implement marshal map feature #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Author
|
Additionally, this PR was created early as a proof-of-concept for the feature. The branch should be considered volatile and subject to force-pushed changes (namely, to remove the " |
Owner
Author
|
The runtime fallbacks idea simply cannot work for marshalling behaviors. See #26. This feature will require new diagnostics to be added. |
monkey0506
force-pushed
the
marshal-map
branch
3 times, most recently
from
295d17d to
fbf940e
Compare
monkey0506
force-pushed
the
interceptors
branch
from
a3bea07 to
76dd14c
Compare
monkey0506
force-pushed
the
marshal-map
branch
from
fbf940e to
bbeb8d2
Compare
monkey0506
force-pushed
the
marshal-map
branch
from
bbeb8d2 to
5667cf7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the
Marshal mapfeature as described in #21. However, it also introduces another parameter that requires static value analysis, obligating the argument in source to be a compile-time constant expression (e.g., the argument must be anewexpression that has a statically parsable collection initializer; or a field-reference to astatic readonlyfield initialized inline).This would introduce a number of new diagnostics, which is undesirable. Instead, this PR will depend on #24. After that issue is resolved, the
MarshalMapshould also be implemented with a runtime fallback condition (also discussed in #21) before this PR is merged.