Skip to content

Conversation

@monkey0722
Copy link
Owner

@monkey0722 monkey0722 commented Dec 31, 2024

This pull request includes multiple changes aimed at improving the build process, updating dependencies, and fixing issues in the codebase. The most important changes include renaming libraries and executables, updating CI configurations, and modifying sorting algorithms to address CI environment issues.

Build and CI Improvements:

  • .github/workflows/cpp-ci.yml: Updated the uses version for actions/checkout from v3 to v4.
  • CMakeLists.txt: Renamed the library from algorithm to clavis_algorithm and the test executable from algorithm_test to clavis_algorithm_test. Updated related CMake commands accordingly.
  • scripts/run_tests.sh: Added set -eux for better debugging and error handling, and updated the script to use ctest for running tests instead of directly invoking the test executable.

Code Improvements:

  • src/graph/bfs.hpp: Replaced std::ranges::reverse with std::reverse to fix compatibility issues.
  • Various sorting headers (src/sorting/merge_sort.hpp, src/sorting/radix_sort.hpp): Commented out usage of std::ranges::move due to CI environment issues and replaced with std::move. [1] [2]

Dependency Updates:

  • Added missing includes for <algorithm> and <vector> in several header files to ensure proper functionality and compatibility. [1] [2] [3] [4] [5] [6] [7] [8]

@monkey0722 monkey0722 self-assigned this Dec 31, 2024
@monkey0722 monkey0722 merged commit baefc7f into main Dec 31, 2024
1 check passed
@monkey0722 monkey0722 deleted the update/setup-v2 branch December 31, 2024 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants