[MRG] Array size info #674

HolterPhylo · 2025-10-10T21:11:05Z

No description provided.

HolterPhylo · 2025-10-10T22:34:05Z

I changed "array=" to "array_size=" in "MXmlProperty.cs", but the output MXML is still showing "array=".
I must be doing something wrong or I forget some instruction to give...
Can you point me to the right track?

monkeyman192 · 2025-10-12T07:50:56Z

Few general comments:

You have added summaries, but in some cases there is the wrong number of /'s (some places had 2 added), and also some summaries are just missing the information.
I think it should be type info, not typed info. The argument can be --typed, but the actual names and descriptions should be type info

HolterPhylo · 2025-10-12T18:54:38Z

I commented out those places with 5 /, I did not want to remove them right away. I do not know enough about function/method definition to know if they are needed or how to write them correctly.
The summaries missing information is because I do not know what the information should be. Sure you can help.
Changed IncludeTypedInfo to IncludeTypeInfo.

HolterPhylo · 2025-10-12T18:55:57Z

I changed "array=" to "array_size=" in "MXmlProperty.cs", but the output MXML is still showing "array=".
I must be doing something wrong or I forget some instruction to give...
Can you point me to the right track?

I still need help here ^

monkeyman192 · 2025-10-13T08:16:50Z

I changed "array=" to "array_size=" in "MXmlProperty.cs", but the output MXML is still showing "array=".
I must be doing something wrong or I forget some instruction to give...
Can you point me to the right track?

I still need help here ^

See suggested changes for fix...

HolterPhylo · 2025-10-13T18:34:13Z

I know we want array_size=‘4’ but I can’t get it to output that. See my comment and the file MXmlProperty.cs

…

On Mon, Oct 13, 2025 at 04:17 monkeyman192 ***@***.***> wrote: *monkeyman192* left a comment (monkeyman192/MBINCompiler#674) <#674 (comment)> I changed "array=" to "array_size=" in "MXmlProperty.cs", but the output MXML is still showing "array=". I must be doing something wrong or I forget some instruction to give... Can you point me to the right track? I still need help here ^ See suggested changes for fix... image.png (view on web) <https://github.com/user-attachments/assets/1e0d7c6d-fb71-4f8f-b590-803c09d5d60b> — Reply to this email directly, view it on GitHub <#674 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAXFQQ335NQ47RANEX46MID3XNNYRAVCNFSM6AAAAACI4AODEGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTGOJWGM3DGNJWGY> . You are receiving this because you authored the thread.Message ID: ***@***.***>

libMBIN/Source/MXML/MXmlProperty.cs

libMBIN/Source/Template/NMSTemplate.cs

monkeyman192 · 2025-10-14T01:46:22Z

I know we want array_size=‘4’ but I can’t get it to output that. See my comment and the file MXmlProperty.cs

sorry, github is weird and I didn't realise I needed to press a different button to submit the suggestions.
You should be able to just press a button to accept my suggested code changes and it will apply them and it should work.

Co-authored-by: monkeyman192 <[email protected]>

…mpiler into ArraySizeInfo # Conflicts: # libMBIN/Source/Template/NMSTemplate.cs

HolterPhylo · 2025-10-15T01:20:16Z

Can you help me understand why "Array" did not work but "ArraySize" does?

HolterPhylo · 2025-10-22T15:40:09Z

Do you think any other corrections are required?

monkeyman192 · 2025-10-22T22:18:17Z

libMBIN/Source/MXML/MXmlFile.cs

-        /// <summary>
-        /// Writes the NMSTemplate object to an .mxml file.
-        /// </summary>
-        /// <param name="outputpath">The location to write the .mxml file.</param>
-        /// <param name="hideVersionInfo">version info is written to the MXML file.</param>
-        public static string WriteTemplate(NMSTemplate template) => WriteTemplate(template, false);


Oh actually, I'm dumb. We should keep this chunk. I clearly didn't look close enough at it before saying we should remove it sorry...

When I add it back, VS does not see any reference to it.
Why do we need it?

monkeyman192 · 2025-10-22T22:21:03Z

Ok, pending me doing one final round of testing, I think this looks good to go (other than that one comment I just left, sorry about that...)

monkeyman192 · 2025-10-28T10:45:40Z

Ok! Looks good to me! Thanks for adding this 😄

HolterPhylo added 3 commits October 7, 2025 17:36

Adds array size info to MXML files

6c82ac4

Adding option --typed

79e771e

Corrected template.SerializeMXML 2nd parameter to false

65dda15

HolterPhylo changed the title ~~Array size info~~ [MRG] Array size info Oct 10, 2025

HolterPhylo changed the title ~~[MRG] Array size info~~ Array size info Oct 10, 2025

monkeyman192 reviewed Oct 14, 2025

View reviewed changes

libMBIN/Source/MXML/MXmlProperty.cs Outdated Show resolved Hide resolved

libMBIN/Source/MXML/MXmlProperty.cs Outdated Show resolved Hide resolved

libMBIN/Source/Template/NMSTemplate.cs Outdated Show resolved Hide resolved

HolterPhylo and others added 6 commits October 13, 2025 23:11

Update libMBIN/Source/MXML/MXmlProperty.cs

05ed72d

Co-authored-by: monkeyman192 <[email protected]>

Update libMBIN/Source/MXML/MXmlProperty.cs

6a7f802

Co-authored-by: monkeyman192 <[email protected]>

Update libMBIN/Source/Template/NMSTemplate.cs

6c07188

Co-authored-by: monkeyman192 <[email protected]>

Changed IncludeTypedInfo to IncludeTypeInfo

d3c14c4

Merge branch 'ArraySizeInfo' of https://github.com/HolterPhylo/MBINCo…

a121d2f

…mpiler into ArraySizeInfo # Conflicts: # libMBIN/Source/Template/NMSTemplate.cs

Changed IncludeTypedInfo to IncludeTypeInfo

66ce270

HolterPhylo changed the title ~~Array size info~~ [MRG] Array size info Oct 15, 2025

HolterPhylo and others added 3 commits October 14, 2025 21:59

Updated reference to type (not typed)

c8fa39d

Remove isField from SerializeMXmlValue

3053339

Merge branch 'development' into ArraySizeInfo

ddfc4fa

monkeyman192 reviewed Oct 22, 2025

View reviewed changes

HolterPhylo added 2 commits October 27, 2025 12:22

Added back WriteTemplate(NMSTemplate template)

ed5057f

Merge branch 'development' into ArraySizeInfo

f4bb7b2

monkeyman192 merged commit d94a754 into monkeyman192:development Oct 28, 2025
6 checks passed

HolterPhylo deleted the ArraySizeInfo branch November 13, 2025 22:25

[MRG] Array size info #674

[MRG] Array size info #674

Uh oh!

Conversation

HolterPhylo commented Oct 10, 2025

Uh oh!

HolterPhylo commented Oct 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

monkeyman192 commented Oct 12, 2025

Uh oh!

HolterPhylo commented Oct 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

HolterPhylo commented Oct 12, 2025

Uh oh!

monkeyman192 commented Oct 13, 2025

Uh oh!

HolterPhylo commented Oct 13, 2025 via email

Uh oh!

Uh oh!

Uh oh!

Uh oh!

monkeyman192 commented Oct 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

HolterPhylo commented Oct 15, 2025

Uh oh!

HolterPhylo commented Oct 22, 2025

Uh oh!

monkeyman192 Oct 22, 2025

Choose a reason for hiding this comment

Uh oh!

HolterPhylo Oct 22, 2025

Choose a reason for hiding this comment

Uh oh!

monkeyman192 commented Oct 22, 2025

Uh oh!

monkeyman192 commented Oct 28, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

HolterPhylo commented Oct 10, 2025 •

edited

Loading

HolterPhylo commented Oct 12, 2025 •

edited

Loading

monkeyman192 commented Oct 14, 2025 •

edited

Loading