Open
Conversation
Also switched to C# 9 with enabled nullability while I was it
…d solo Various other changes as well In-game stuff isn't ready yet
- Fixed schema url - Bumped dependency versions - Bumped game and mod versions
ErisApps
force-pushed
the
feature/rewrite
branch
from
7871fbb to
acce1d8
Compare
Improved config generation and binding
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So... This PR aims to fix/rewrite the mod to some degree.
The score counting on the results screen works just fine (with the HSV integration being restored again)
However, the in-game counters aren't.
This also brings in a variety of QoL changes.
The BSMT.T change implies that the manifest becomes the single source of truth for mod version by the way.
One last thing that hasn't been done yet, is the bumping of both the game and mod versions.
Please let me know if I need to add/change anything else.