refactor(backend): improve redis and json.parse type safety with zod (@byseif21) #6481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fehmer
reviewed
Apr 22, 2025
Contributor
Author
|
Hi @fehmer , thank you for the feedback. Could you please let me know if there is anything else needs changing too? |
Miodec
reviewed
Apr 23, 2025
start approved quote with -1, throw if unchanged no need for typecast anymore
Miodec
reviewed
Apr 23, 2025
Miodec
reviewed
Apr 23, 2025
Miodec
reviewed
Apr 23, 2025
Miodec
reviewed
Apr 23, 2025
Miodec
reviewed
Apr 23, 2025
Miodec
reviewed
Apr 23, 2025
Miodec
added
the
waiting for update
github-actions
bot
removed
the
waiting for update
Contributor
|
Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. |
github-actions
bot
added
the
waiting for update
github-actions
bot
removed
the
waiting for update
github-actions
bot
added
the
waiting for review
Miodec
reviewed
Apr 24, 2025
github-actions
bot
removed
the
waiting for review
Miodec
reviewed
Apr 24, 2025
use this schema as add result options modify function props structure slightly remove last activity timestamp modifying as its already passed into the function
Member
|
@byseif21 modified the xp leaderboard code a bit, check my latest commit and let me know what you think |
Contributor
Author
Very nice work, that's even cleaner! seems perfect to me. |
Miodec
changed the title
Member
|
Thanks! |
Contributor
Author
Glad to contribute on that and thanks for the help |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
refactored backend files to enhance type safety and reliability using Zod validation and Redis instead of JSON.parse , I tried to avoid the files that isn't necessary tho so I hope I don't miss any or included unnecessary ones!! didn't fully test only verified code compilation and partial tests without Redis!!.
Should Close #5881
Related to #6207